buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45024, Incorrect documentation of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45024: Incorrect documentation of TCP_WRITE_FLAG_MORE

Submitted by:  Edgar Bonet <ebonet>
Submitted on:  Tue 05 May 2015 02:31:07 PM UTC  
 
Category: DocumentationSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 05 Aug 2015 07:21:00 PM UTC, comment #1:

Fixed, thanks for the patch.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 05 May 2015 02:31:07 PM UTC, original submission:

lwip/doc/rawapi.txt documents TCP_WRITE_FLAG_MORE in a
self-contradictory way:

"If this is given, the PSH flag is set [...]. If this flag is given,
the PSH flag is not set."

The Doxygen comments in lwip/src/core/tcp_out.c provide coherent, but
incorrect documentation of the same flag:

"TCP_WRITE_FLAG_MORE (0x02) for TCP connection, PSH flag will be set
on last segment sent"

According to the source code (lwip/src/core/tcp_out.c:719), if
TCP_WRITE_FLAG_MORE is given, the PSH flag is not set.

The attached patch fixes these documents.

Edgar Bonet <ebonet>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by ebonet (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 05 Aug 2015 07:21:00 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Tue 05 May 2015 02:31:07 PM UTCebonetAttached File-=>Added 0001-Fix-documentation-of-TCP_WRITE_FLAG_MORE.patch, #33922

    Back to the top


    Powered by Savane 3.1-cleanup1