buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45027, Unix echop: option --debug does...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45027: Unix echop: option --debug does not work

Submitted by:  Edgar Bonet <ebonet>
Submitted on:  Tue 05 May 2015 03:48:53 PM UTC  
 
Category: Platform portsSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Tue 05 May 2015 08:20:19 PM UTC, comment #1:

Indeed, applied, thank you Edgar.

By the way, we should at some point remove mintapif.* from minimal and use tapif.c instead, they are very close from each other from a quick sight.

There are threads involved but adding #if NO_SYS around them should be enough.

Sylvain Rochet <gradator>
Project Member
Tue 05 May 2015 03:48:53 PM UTC, original submission:

In the Unix port, both the minimal project (echop) and simhot provide a
--debug option. This option works on simhost but has no effect on echop.

On both projects, the option sets a global variable debug_flags which,
according to the comments, is exported in lwipopts.h. The comment is
correct in simhot, where lwipopts.h contains

extern unsigned char debug_flags;
#define LWIP_DBG_TYPES_ON debug_flags

but the variable is not exported in echop.

The attached patch fixes the issue by copying the relevant lines from
unixsim/lwipopts.h into minimal/lwipopts.h.

Edgar Bonet <ebonet>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by ebonet (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 May 2015 08:20:19 PM UTCgradatorStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 05 May 2015 03:48:53 PM UTCebonetAttached File-=>Added 0001-Unix-port-fix-debug-option-in-echop.patch, #33926

    Back to the top


    Powered by Savane 3.1-cleanup1