bugGPSD - Bugs: bug #45083, ppsthread.c:1091: erroneous...

 
 

bug #45083: ppsthread.c:1091: erroneous rejection of PPS

Submitted by:  None
Submitted on:  Tue 12 May 2015 08:53:12 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Gary E. Miller <garyemiller>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 05 Jan 2016 01:35:12 AM UTC, comment #1:

Thanks Anonymous, whoever you are. A stupid bug on my part. Fixed in commit a19b22f0fcf087ae516a8ea07d4e710a1bba45dd.

This should be in gpsd 3.16 when it comes out.

Gary E. Miller <garyemiller>
Project AdministratorIn charge of this item.
Tue 12 May 2015 08:53:12 AM UTC, original submission:

The condition on line 1091 of ppsthread.c seems wrong:

1090: } else if ( ( 2 < delay.tv_sec)
1091: || ( 1 == delay.tv_sec && 100000000 > delay.tv_nsec ) ) {
1092: /* system clock could be slewing so allow 1.1 sec delay */

Should the comparison not be 100000000 < delay.tv_nsec ?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by garyemiller (Posted a comment)
  • -unavailable- added by esr (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Sep 2017 04:36:53 AM UTCesrOpen/ClosedOpen=>Closed
    Tue 05 Jan 2016 01:35:12 AM UTCgaryemillerStatusInvalid=>Fixed
      Summaryppsthread.c:1091: erroneous rejection of PPS?=>ppsthread.c:1091: erroneous rejection of PPS
    Mon 04 Jan 2016 10:25:14 PM UTCesrStatusNone=>Invalid
      Assigned toNone=>garyemiller

    Back to the top


    Powered by Savane 3.1-cleanup1