buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45454, pbuf_take_at() skips write and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45454: pbuf_take_at() skips write and returns OK if offset is at start of pbuf in chain

Submitted by:  Erik Ekman <yarrick>
Submitted on:  Wed 01 Jul 2015 11:03:30 AM UTC  
 
Category: pbufsSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 05 Aug 2015 06:58:27 PM UTC, comment #4:

Right: fixed, thanks for reporting :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 05 Aug 2015 06:39:43 PM UTC, comment #3:

This one is also merged. If you don't want the code in patch #8678 you can close that also.

Erik Ekman <yarrick>
Project Member
Wed 01 Jul 2015 11:16:28 AM UTC, comment #2:

Added new patch which removes the if statement, since it was always true.

(file #34353)

Erik Ekman <yarrick>
Project Member
Wed 01 Jul 2015 11:06:11 AM UTC, comment #1:

Apply patch #8677 before this one to make test cases run again.
Also look at patch #8678 to clean up the unittest warnings.

Erik Ekman <yarrick>
Project Member
Wed 01 Jul 2015 11:03:30 AM UTC, original submission:

Off by one in bounds check caused write not to happen if supplied is 0, or buf->len in case of chained pbufs.

Fix is attached, together with test cases to verify it.

Erik Ekman <yarrick>
Project Member

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by yarrick (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 05 Aug 2015 06:58:27 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Wed 01 Jul 2015 11:16:28 AM UTCyarrickAttached File-=>Added v2-Fix-edge-case-in-pbuf_take_at.patch, #34353
    Wed 01 Jul 2015 11:03:30 AM UTCyarrickAttached File-=>Added 0001-Fix-off-by-one-in-pbuf_take_at.patch, #34352

    Back to the top


    Powered by Savane 3.1-cleanup1