buglwIP - A Lightweight TCP/IP stack - Bugs: bug #46093, Move IP6_ROUTE() hook to after LL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46093: Move IP6_ROUTE() hook to after LL processing

Submitted by:  Ivan Delamer <idelamer>
Submitted on:  Thu 01 Oct 2015 03:28:32 PM UTC  
 
Category: IPv6Severity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Ivan Delamer <idelamer>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Sat 05 Mar 2016 01:19:19 PM UTC, comment #2:

fixed by moving the hook further down

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 01 Oct 2015 07:09:24 PM UTC, comment #1:

The proposed changes looks fine to me (at least for all valid usages of the hook that I could think of).

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 01 Oct 2015 03:28:32 PM UTC, original submission:

ip6_route() starts with a call to LWIP_HOOK_IP6_ROUTE() if defined.

However, this is done before checking if the destination is a link-local address, or an address that matches a configured subnet.

It seems that it would make more sense to have the hook just before the call to nd6_select_router(), after the LL and local subnet processing.

This way, the hook function can work on remote addresses and doesn't need to duplicate the logic for local addresses.

Ivan Delamer <idelamer>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by idelamer (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 05 Mar 2016 01:19:19 PM UTCgoldsimonStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1