buglwIP - A Lightweight TCP/IP stack - Bugs: bug #46094, IPv4 routing hook functions should...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46094: IPv4 routing hook functions should be moved

Submitted by:  Ivan Delamer <idelamer>
Submitted on:  Thu 01 Oct 2015 03:32:39 PM UTC  
 
Category: IPv4Severity: 2 - Minor
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Sat 05 Mar 2016 02:53:33 PM UTC, comment #2:

Done

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 01 Oct 2015 07:14:50 PM UTC, comment #1:

This change looks good as well. Some strange things people do in their hook function could stop working, but the intention of the hook (allowing to extend routing) will be easier that way.

Maybe loopback traffic should be handled before the hook as well.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 01 Oct 2015 03:32:39 PM UTC, original submission:

LWIP_HOOK_IP4_ROUTE() is called (if defined) at the beginning of the ip4_route() function.

Maybe this should be moved down to after we check for a match to our configured netifs, but before we check for the default router netif.

This way, the hook function doesn't need to duplicate the checks for local subnet routing.

This only applies to LWIP_HOOK_IP4_ROUTE and not to LWIP_HOOK_IP4_ROUTE_SRC

Ivan Delamer <idelamer>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by idelamer (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 05 Mar 2016 02:53:33 PM UTCgoldsimonStatusNeed Info=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1