buglwIP - A Lightweight TCP/IP stack - Bugs: bug #46145, tcp_send_empty_ack() uses wrong...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46145: tcp_send_empty_ack() uses wrong netif with LWIP_HOOK_IP4_ROUTE_SRC

Submitted by:  Milan Cermak <cermmik>
Submitted on:  Wed 07 Oct 2015 12:37:22 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 07 Oct 2015 12:56:41 PM UTC, comment #1:

Fixed, thanks for the patch.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 07 Oct 2015 12:37:22 PM UTC, original submission:

I have defined my own LWIP_HOOK_IP4_ROUTE_SRC function and find out that ACK packets are routed incorrectly. After lwIP code review I found that function tcp_send_empty_ack() in tcp_out.c calls ip_route(PCB_ISIPV6(pcb), &pcb->remote_ip, &pcb->local_ip); which has swapped IPs compared to its definition #define ip_route(isipv6, src, dest).

Milan Cermak <cermmik>

 

Attached Files
file #35091:  tcp_out.patch added by cermmik (418B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by cermmik (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 07 Oct 2015 12:56:41 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Wed 07 Oct 2015 12:37:22 PM UTCcermmikAttached File-=>Added tcp_out.patch, #35091

    Back to the top


    Powered by Savane 3.1-cleanup1