buglwIP - A Lightweight TCP/IP stack - Bugs: bug #46278, The wraparound case for getting...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46278: The wraparound case for getting difference between 2 u32_t value needs fix

Submitted by:  Axel Lin <axellin>
Submitted on:  Fri 23 Oct 2015 08:20:46 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Fri 23 Oct 2015 09:53:00 AM UTC, comment #2:

Oops, my bad. Something wrong in my test.
Please mark this issue invalid.

Axel Lin <axellin>
Fri 23 Oct 2015 09:28:00 AM UTC, comment #1:

Hello,

I don't follow you: (uint32_t)0 - (uint32_t)4294967293 = 3

The commit is fine for me.

Sylvain

Sylvain Rochet <gradator>
Project Member
Fri 23 Oct 2015 08:20:46 AM UTC, original submission:

Hi,
The commit cf1be4ae2d2b80b87df9b1e199e60e301ce6d1c5
"fixed bug #34541: LWIP_U32_DIFF is unnecessarily complex: removed that define"

looks wrong to me in the wrap around case.
For example, if now is wrap around to 0 and timeouts_last_time is 4294967293.
The correct diff is: 3
but with current code, the diff is: 4294967293.

I think that commit needs to be reverted.
comments?

Axel Lin <axellin>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by axellin (Submitted the item)
  • -unavailable- added by axellin
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 23 Oct 2015 09:56:49 AM UTCgradatorStatusNone=>Invalid
      Open/ClosedOpen=>Closed
    Fri 23 Oct 2015 08:20:46 AM UTCaxellinCarbon-Copy-=>Added axellin

    Back to the top


    Powered by Savane 3.1-cleanup1