bugGPSD - Bugs: bug #46940, driver_rtcm2.c build fails on OSX...

 
 

bug #46940: driver_rtcm2.c build fails on OSX PPC

Submitted by:  Fred Wright <fhgwright>
Submitted on:  Wed 20 Jan 2016 11:57:19 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 20 Jan 2016 11:57:19 PM UTC, original submission:

OSX 10.5, when building for PPC, defines _BIG_ENDIAN as 1, which satisfies the BSD ifdef, but doesn't have the expected value. The result is an "endianness macros are not defined" error. This bug goes back at least as far as 3.14, but I don't think it was ever reported here.

The fix is quite simple - moving the Darwin __BYTE_ORDER setup ahead of the BSD __BYTE_ORDER setup so that the Darwin definitions take precedence. This should have no effect on a platform that doesn't define the __DARWIN_xxx macros.

The actual fix is from ryandesign@macports.org, though I added a comment line clarifying the reason that the order matters.

Attached is the relevant patch, based on the 3.16 release source.

Fred Wright <fhgwright>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36104:  patch-driver_rtcm2.c.diff added by fhgwright (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by fhgwright (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Sep 2017 04:33:32 AM UTCesrOpen/ClosedOpen=>Closed
    Thu 21 Jan 2016 06:32:39 PM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Wed 20 Jan 2016 11:57:19 PM UTCfhgwrightAttached File-=>Added patch-driver_rtcm2.c.diff, #36104

    Back to the top


    Powered by Savane 3.1-cleanup1