bugGPSD - Bugs: bug #47227, regress-driver may fail on binary...

 
 

bug #47227: regress-driver may fail on binary logs

Submitted by:  Fred Wright <fhgwright>
Submitted on:  Mon 22 Feb 2016 08:35:26 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 22 Feb 2016 08:35:26 PM UTC, original submission:

This is already fixed, but I realized belatedly that I should have filed a tracking bug for it anyway. From commit 8cfa92:

Fixes manual use of regress-driver with binary logs.

At present, running regress-driver manually on binary logs may fail,
even though it works when run from scons. This is due to running in
an unsanitized environment when run manually.

The problem is that sed is being used to filter the daemon output, and
it's not really kosher to be using sed on binary data. Whether the
"working" cases involve its working "correctly" or merely
"reproducibly" is unclear, but what is clear is that in can choke on
binary data with certain settings of the LANG environment variable (in
particular, "en_US.UTF-8" is known to fail on ac12_binary). The fix
is merely to unset LANG in regress-driver.

Failures on binary data are also not very informative due to diff
simply reporting "binary files differ". That can be fixed by adding
the -b option to diff, but the resulting output can contain characters
that screw up the terminal, so it's probably not a good default.

This can be marked fixed.

Fred Wright <fhgwright>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by fhgwright (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Sep 2017 04:32:54 AM UTCesrOpen/ClosedOpen=>Closed
    Tue 23 Feb 2016 10:30:00 PM UTCesrStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1