bugThe FreeType Project - Bugs: bug #47259, [lwip-1.4.1 + ptp1588] - Multicast...

 
 

bug #47259: [lwip-1.4.1 + ptp1588] - Multicast addresses

Submitted by:  Evripidis Karseras <evripidis>
Submitted on:  Thu 25 Feb 2016 06:34:01 PM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: InvalidPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 26 Feb 2016 09:09:11 AM UTC, comment #5:

What a confusion !!! Thank you Werner.

Evripidis Karseras <evripidis>
Fri 26 Feb 2016 05:43:44 AM UTC, comment #4:

You are on the wrong bug tracker. This is FreeType, and I thought that your previous comment indicates exactly that.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Fri 26 Feb 2016 12:15:58 AM UTC, comment #3:

Any other comments please ?

Regards,
Evripidis

Evripidis Karseras <evripidis>
Thu 25 Feb 2016 11:55:30 PM UTC, comment #2:

:-) Closed.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Thu 25 Feb 2016 06:34:51 PM UTC, comment #1:

This is for ptp over ipv4 obviously.

Evripidis Karseras <evripidis>
Thu 25 Feb 2016 06:34:01 PM UTC, original submission:

There is an issue in the following file:

lwip-1.4.1\src\core\ipv4\ip.c file (line 412)

if ( ip_addr_cmp(&current_iphdr_dest, &(netif->ip_addr))
|| ip_addr_isbroadcast(&current_iphdr_dest, netif)
)

There is no provision for multicast addresses needed for PTP1588. There is another if statement before the above to account for IGMP and that is where the multicast check is done. But PTP does not used IGMP flags so even by enabling IGMP, the PTP packets never get through.

This has been tested on a port for a T.I device and after the following modification PTPD would work fine:

if ( ip_addr_cmp(&current_iphdr_dest, &(netif->ip_addr))
|| ip_addr_isbroadcast(&current_iphdr_dest, netif)
#if LWIP_PTPD
|| ip_addr_ismulticast(&current_iphdr_dest)
#endif /* LWIP_PTPD */
)

Basically there is a clause added to make sure multicast is handled in case PTPD is enabled.

Evripidis Karseras

Evripidis Karseras <evripidis>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by evripidis (Submitted the item)
  • -unavailable- added by evripidis
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 25 Feb 2016 11:55:30 PM UTCwlStatusNone=>Invalid
      Assigned toNone=>wl
      Open/ClosedOpen=>Closed
    Thu 25 Feb 2016 06:34:01 PM UTCevripidisCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1