buglwIP - A Lightweight TCP/IP stack - Bugs: bug #47260, Implementation bugs in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47260: Implementation bugs in LWIP_FIONREAD_LINUXMODE for UDP

Submitted by:  Joel Cunningham <jcunningham>
Submitted on:  Thu 25 Feb 2016 07:00:55 PM UTC  
 
Category: sockets/netconnSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Joel Cunningham <jcunningham>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Thu 25 Feb 2016 09:07:06 PM UTC, comment #3:

Submitted in 2a8398dfb8a07c0f9fda41411954904e0cd9df21

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Thu 25 Feb 2016 08:53:12 PM UTC, comment #2:

I guess nobody was using the feature. I'll submit the patch

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Thu 25 Feb 2016 08:22:19 PM UTC, comment #1:

Good fix. How come this is in there for so long?

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 25 Feb 2016 07:00:55 PM UTC, original submission:

The UDP support with LWIP_FIONREAD_LINUXMODE set to 1 has a couple of bugs in the implementation:

1) if sock->lastdata is not NULL, the output pointer of FIONREAD is not set
2) argp is being cast to u16_t * even though the other FIONREAD code uses a int. Linux code uses an int
3) sock->lastoffset was not set even though we are setting sock->lastdata. This could cause a problem on the next recv() call

1) was discovered when calling ioctl() twice in a row without a recv() in between

The attached patch fixes these issues

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by jcunningham (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 25 Feb 2016 09:07:06 PM UTCjcunninghamStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 25 Feb 2016 08:53:12 PM UTCjcunninghamAssigned toNone=>jcunningham
    Thu 25 Feb 2016 07:00:55 PM UTCjcunninghamAttached File-=>Added 0001-Fix-bug-in-FIONREAD-handling-in-LINUXMODE.patch, #36459

    Back to the top


    Powered by Savane 3.1-cleanup1