buglwIP - A Lightweight TCP/IP stack - Bugs: bug #47361, Remove ppp_init()

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47361: Remove ppp_init()

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Tue 08 Mar 2016 08:11:47 AM UTC  
 
Category: PPPSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Sylvain Rochet <gradator>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Thu 21 Apr 2016 09:37:47 PM UTC, comment #2:

I agree ppp_init is not really useful, I already thought about removing this one previously. Removed.

> I'd even completelty remove 'magic_randomseed' when LWIP_RAND() is defined.


The point is, I'm not confident regarding cryptography (only a very few developers around the world actually are), so I prefer avoid breaking randomness just for the sake of removing a function call :-)

At least, currently, even with very bad randomness gathered from the user LWIP_RAND function (or even no randomness at all) we still have a properly randomized pool in PPP.

Sylvain Rochet <gradator>
Project MemberIn charge of this item.
Wed 16 Mar 2016 03:35:38 PM UTC, comment #1:

Sylvain, any input on this?

Simon Goldschmidt <goldsimon>
Project Administrator
Tue 08 Mar 2016 08:11:47 AM UTC, original submission:

ppp_init() does not seem to be used. The only thing it does is calling magic_init(), which is not required because it its called again later from ppp_input().

Also, the time from startup is rather constant, so calling sys_jiffies() from ppp_init() does not create a random number.

I'd even completelty remove 'magic_randomseed' when LWIP_RAND() is defined.

Simon Goldschmidt <goldsimon>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Apr 2016 09:37:47 PM UTCgradatorCategoryNone=>PPP
      StatusNone=>Fixed
      Assigned toNone=>gradator
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1