buglwIP - A Lightweight TCP/IP stack - Bugs: bug #47447, UDP: use netif addr as source for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47447: UDP: use netif addr as source for multicast bound sockets

Submitted by:  Joel Cunningham <jcunningham>
Submitted on:  Thu 17 Mar 2016 07:46:45 PM UTC  
 
Category: UDPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Joel Cunningham <jcunningham>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Mon 18 Apr 2016 08:42:16 PM UTC, comment #3:

Great, patch submitted in 8ac1b4825af1439601962d277c65e61bdc3929d4

If someone needs broadcast support, it can be added later

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Mon 18 Apr 2016 06:19:24 PM UTC, comment #2:

Sorry for the late response.
Yes, the check for multicast looks OK to me. I wouldn't really bother for broadcas, though...

Simon Goldschmidt <goldsimon>
Project Administrator
Wed 13 Apr 2016 08:58:05 PM UTC, comment #1:

Anyone have a chance to look at this bug yet?

It seems pretty straight forward to me, only question is do we want to add additional handling for sockets bound to global/subnet broadcast addresses

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.
Thu 17 Mar 2016 07:46:45 PM UTC, original submission:

Sockets bound to multicast addresses fail to transmit in udp_sendto_if() because pcb->local_ip doesn't match the IP address of the selected output netif.

The attached patch handles this case similarly to the INADDR_ANY case by using the netif address as the source IP address.

Additionally, I think this problem also applies to sockets bound to global broadcast and subnet broadcast addresses, but I don't have an example on hand to test with

Joel Cunningham <jcunningham>
Project MemberIn charge of this item.

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by jcunningham (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 18 Apr 2016 08:42:16 PM UTCjcunninghamStatusNone=>Fixed
      Assigned toNone=>jcunningham
      Open/ClosedOpen=>Closed
    Thu 17 Mar 2016 07:46:45 PM UTCjcunninghamAttached File-=>Added 0001-udp-use-netif-addr-as-src-for-multicast-sockets.patch, #36676

    Back to the top


    Powered by Savane 3.1-cleanup1