bugThe FreeType Project - Bugs: bug #47726, free of note assigned FT_Outline...

 
 

bug #47726: free of note assigned FT_Outline member

Submitted by:  None
Submitted on:  Mon 18 Apr 2016 11:06:05 AM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.6.4

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 25 Jun 2016 04:11:21 PM UTC, comment #3:

You are right. Now in git, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Wed 22 Jun 2016 07:46:35 PM UTC, comment #2:

The fix was incomplete. outline.points can still be unassigned if the first FT_NEW_ARRAY fails. It should also be set to NULL at line 1749.

Note that the FT_NEW_ARRAY modifies a local 'points', not the 'outline.points'.

Jarkko Pöyry <jarkkopoyry>
Sun 24 Apr 2016 06:15:07 AM UTC, comment #1:

Fixed in git, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Mon 18 Apr 2016 11:06:05 AM UTC, original submission:

In src/truetype/ttgload.c on line 1710 is a goto which could jumpt to exit when one member of FT_Outline is not assigned yet.

Here the code:

...
/* construct an outline structure for */
/* communication with `TT_Vary_Apply_Glyph_Deltas' */
outline.n_points = (short)( gloader->current.num_subglyphs + 4 );
outline.n_contours = outline.n_points;

if ( FT_NEW_ARRAY( points, outline.n_points ) ||
FT_NEW_ARRAY( tags, outline.n_points ) ||
FT_NEW_ARRAY( contours, outline.n_points ) )
goto Exit1;

subglyph = gloader->current.subglyphs;
...

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jarkkopoyry (Posted a comment)
  • -unavailable- added by wl (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 24 Apr 2016 06:15:07 AM UTCwlStatusNone=>Fixed
      Assigned toNone=>wl
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.6.4

    Back to the top


    Powered by Savane 3.1-cleanup1