buglwIP - A Lightweight TCP/IP stack - Bugs: bug #48688, pppoe_connect() may return wrong...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48688: pppoe_connect() may return wrong error codes

Submitted by:  Dirk Ziegelmeier <dziegel>
Submitted on:  Wed 03 Aug 2016 11:20:38 AM UTC  
 
Category: PPPSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Sylvain Rochet <gradator>
Open/Closed: ClosedPlanned Release: 2.0.0
lwIP version: git head

Thu 04 Aug 2016 10:18:11 PM UTC, comment #2:

Fixed by removing the condition which returned EBUSY, it is always false.

About 0 used instead of ERR_OK, I failed to see one of them in the whole PPPoE code on features that are enabled.

Sylvain Rochet <gradator>
Project MemberIn charge of this item.
Wed 03 Aug 2016 06:44:08 PM UTC, comment #1:

A correct replacement for EBUSY would probably be "ERR_ALREADY".

  1. is not a literal err_t, but ERR_OK is 0, so this is more of a cosmetic change...
Simon Goldschmidt <goldsimon>
Project Administrator
Wed 03 Aug 2016 11:20:38 AM UTC, original submission:

- may return EBUSY which is not an err_t
- may return 0 which is not an err_t

Dirk Ziegelmeier <dziegel>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gradator (Posted a comment)
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by dziegel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 07 Aug 2016 10:48:32 AM UTCgradatorOpen/ClosedOpen=>Closed
    Thu 04 Aug 2016 10:18:11 PM UTCgradatorStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1