bugpng++, a C++ wrapper for libpng - Bugs: bug #49174, Compiler warning: Unused parameter...

 
 

bug #49174: Compiler warning: Unused parameter 'fmt'

Submitter:  None
Submitted:  Sat 24 Sep 2016 02:52:34 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 24 Sep 2016 02:52:34 PM UTC, original submission:  

Clang warns me about trace_io_transform's parameter fmt:


io_base.hpp:42:32: warning: unused parameter 'fmt'


which is because my build, having DEBUG_IO_TRANSFORM disabled, renders the parameter useless. The simplest solution should be to make the parameter unnamed. E.g. replace


static void
trace_io_transform(char const* fmt, ...)
{
#ifdef DEBUG_IO_TRANSFORM
    va_list va;
    va_start(va, fmt);
    fprintf(stderr, "TRANSFORM_IO: ");
    vfprintf(stderr, fmt, va);
    va_end(va);
#endif
}


with


static void
#ifdef DEBUG_IO_TRANSFORM
trace_io_transform(char const* fmt, ...)
{
    va_list va;
    va_start(va, fmt);
    fprintf(stderr, "TRANSFORM_IO: ");
    vfprintf(stderr, fmt, va);
    va_end(va);
}
#else
trace_io_transform(char const*, ...)
{
}
#endif


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-c373.
Corresponding source code