buglwIP - A Lightweight TCP/IP stack - Bugs: bug #4988, mintapif_init should have a return...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #4988: mintapif_init should have a return value of type err_t

Submitted by:  None
Submitted on:  Fri 29 Aug 2003 07:02:33 AM UTC  
 
Category: ContribSeverity: 2 - Minor
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Wed 10 Sep 2003 05:22:26 PM UTC, comment #1:

Fixed in the DEVEL tree, but the minimal project has not been brought into line with other changes (such as the RAW IP code) so does not compile.

Kieran Mansley <kieranm>
Project Administrator
Fri 29 Aug 2003 07:02:33 AM UTC, original submission:

In the contrib-20030720 archive under ports/unix/proj/minimal the return value of the function mintapif_init should be err_t and not void. The mintapif_init function shall return ERR_OK when correctly run. Failing to do so causes the minimal example not to start.

The mintapif_init function is sent as the second last argument to the netif_add function in proj/unix/ports/minimal/main.c:
netif = netif_add(&ipaddr, &netmask, &gw, NULL, mintapif_init, ip_input);

The specification of netif_add says:

struct netif *
netif_add(struct ip_addr ipaddr, struct ip_addr netmask,
struct ip_addr *gw,
void *state,
err_t (* init)(struct netif *netif),
err_t (* input)(struct pbuf p, struct netif netif))

Thus, mintapif_init should return a value of type err_t.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 10 Sep 2003 05:22:26 PM UTCkieranmSeverity3 - Normal=>(Error - Not Found)
  StatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1