buglwIP - A Lightweight TCP/IP stack - Bugs: bug #50042, ETHADDR16_COPY from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #50042: ETHADDR16_COPY from netif->hwaddr

Submitted by:  Daniel Elstner <danielk>
Submitted on:  Thu 12 Jan 2017 09:20:21 PM UTC  
 
Category: ARPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: 2.0.0

Fri 13 Jan 2017 07:19:15 AM UTC, comment #2:

Thanks for reporting!

Dirk Ziegelmeier <dziegel>
Project Member
Fri 13 Jan 2017 02:18:48 AM UTC, comment #1:

Addendum: ETHADDR32_COPY(&ethhdr->dest, dst) is likewise incorrect for the destination if ETH_PAD_SIZE is not 0.

I wonder if these macros should just be dropped. No idea if anyone actually makes use of the option to customize those.

Daniel Elstner <danielk>
Thu 12 Jan 2017 09:20:21 PM UTC, original submission:

ETHADDR16_COPY is supposed to work with 16-bit aligned source and destination, but etharp_input() uses the macro with source netif->hwaddr, which is not 16-bit aligned.

struct netif::hwaddr could easily be made 16-bit aligned by re-arranging the fields surrounding it. Alternatively, etharp_input() should not use ETHADDR16_COPY() in this case.

Daniel Elstner <danielk>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dziegel (Updated the item)
  • -unavailable- added by danielk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 13 Jan 2017 07:18:59 AM UTCdziegelStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1