bugProject: Starfighter - Bugs: bug #50390, Seeing "Corrupt Game...

 
 

bug #50390: Seeing "Corrupt Game Data" frequently with version 1.6

Submitted by:  None
Submitted on:  Fri 24 Feb 2017 10:42:57 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 24 Feb 2017 02:43:44 PM UTC, comment #2:

This is already fixed in Git (I fixed it some months ago). If I remember correctly, the source of the problem was a failure to record the stationed planet name.

Version 1.7 will be out soon. I was holding back because I was hoping to compile a version for the OpenPandora (since it's now possible to build the game for an 800x480 resolution), but it seems the upgrade to SDL2 has made that too complex to be worth it.

> Opening text files as binary is also a bad idea.


Is there a particular reason?

Julie Marchant <onpon4>
Project Administrator
Fri 24 Feb 2017 11:17:52 AM UTC, comment #1:

I've noticed line 5 to be empty in save games. I'm in mission "Mordor, Poswic".

Workaround found:
I've written "Poswic" to line 5 with a text editor and I see "Mordor, Poswic" now.

So the station name is not saved to line 5 of the save game file.

Anonymous
Fri 24 Feb 2017 10:42:57 AM UTC, original submission:

Although game data is fine and can be loaded correctly, "Corrupt Game Data" is often visible with version 1.6.

This is especially annoying if saving and seeing the just saved data to be corrupted.

The version of the save file can be determined. But there is no station name included in save data. The game tries to read it in src/save.cpp line 80:

if (fscanf(fp, "%[^\n]%c%[^\n]%c%d %d %d%c%[^\n]%c",
&system, stationedName) < 2)
{
sprintf(saveSlot[i], "Corrupt Game Data");
}
else
{
sprintf(saveSlot[i], "%s, %s", systemNames[system],
stationedName);
}

stationedName is unused.

Opening text files as binary is also a bad idea. Please fix that!

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by onpon4 (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 24 Feb 2017 02:43:43 PM UTConpon4StatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1