bugThe FreeType Project - Bugs: bug #50586, [ftview] Stop waterfall mode...

 
 

bug #50586: [ftview] Stop waterfall mode repeating the default glyph to the end of each line after the display text

Submitted by:  Brian Nixon <bnixon>
Submitted on:  Sun 19 Mar 2017 11:55:20 AM UTC  
 
Severity: 3 - NormalItem Group: Wishlist
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.8

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 20 Mar 2017 12:36:27 PM UTC, comment #3:

An image says more than 1000 words :-)

I've applied `ftview-waterfall-break.patch'.

Thanks a lot!

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Mon 20 Mar 2017 12:01:28 PM UTC, comment #2:

Screenshots attached.

Thank you for your patience; I won’t take up any more of your time.

(file #40033, file #40034, file #40035)

Brian Nixon <bnixon>
Mon 20 Mar 2017 04:48:52 AM UTC, comment #1:

I don't have enough time to play with your patches, so please attach before-after images!

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Sun 19 Mar 2017 11:55:20 AM UTC, original submission:

With faces whose default glyph is not empty, the waterfall display doesn’t look very nice.

If the intent is to repeat the text (as in text mode, which doesn’t suffer from this problem because it doesn’t prefix the displayed string with the font size), try the attached ftview-waterfall-repeat.patch. (This patch also removes a potential early return which is implemented the same as in Render_Text() but not really appropriate for waterfall.)

If the intent is to draw only one occurrence of the text, try ftview-waterfall-break.patch.

Brian Nixon <bnixon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40026:  ftview-waterfall-repeat.patch added by bnixon (530B - application/octet-stream)
file #40027:  ftview-waterfall-break.patch added by bnixon (527B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by bnixon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 Mar 2017 12:36:27 PM UTCwlStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.8
    Mon 20 Mar 2017 12:01:28 PM UTCbnixonAttached File-=>Added ftview-waterfall-before.png, #40033
      Attached File-=>Added ftview-waterfall-after-repeat.png, #40034
      Attached File-=>Added ftview-waterfall-after-break.png, #40035
    Mon 20 Mar 2017 04:48:52 AM UTCwlStatusNone=>Need Info
      Assigned toNone=>wl
    Sun 19 Mar 2017 11:55:20 AM UTCbnixonAttached File-=>Added ftview-waterfall-repeat.patch, #40026
      Attached File-=>Added ftview-waterfall-break.patch, #40027

    Back to the top


    Powered by Savane 3.1-cleanup1