buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51230, Fix comment line

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51230: Fix comment line

Submitted by:  Andrey Vinogradov <andreyvinogradov>
Submitted on:  Tue 13 Jun 2017 11:48:26 AM UTC  
 
Category: appsSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Tue 13 Jun 2017 07:15:06 PM UTC, comment #1:

Fixed, thanks for reporting.

> BTW, there is the best place to put declaration of this function?


I've changed httpd.c to include LWIP_HOOK_FILENAME, since this is the best place/file to declare such functions.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 13 Jun 2017 11:48:26 AM UTC, original submission:

src/include/lwip/apps/httpd_opts.h, line 274:
The function have this signature: u16_t fn(struct tcp_pcb* pcb);

The function should have the following signature:
u16_t fn(struct altcp_pcb* pcb);

BTW, there is the best place to put declaration of this function? I'm corrently placed it's declaration right in httpd.c file, but it's no good. If I place it in lwipopts.h compiler says that it doesn't know altcp_pcb structure and some other things.

Andrey Vinogradov <andreyvinogradov>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by andreyvinogradov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 13 Jun 2017 07:15:06 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1