buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51232, fix memcpy bug

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51232: fix memcpy bug

Submitted by:  Andrey Vinogradov <andreyvinogradov>
Submitted on:  Tue 13 Jun 2017 01:25:46 PM UTC  
 
Category: appsSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Tue 13 Jun 2017 07:54:43 PM UTC, comment #1:

The suggested fix doesn't compile for me. However, sizeof(CRLF) is already 3, so the additional "\0" is indeed not necessary...

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 13 Jun 2017 01:25:46 PM UTC, original submission:

src/apps/httpd/httpd.c, line 944:
SMEMCPY(&hs->hdr_content_len[len], CRLF "\0", 3);

copy 3 bytes of the 4 byte string < "\r\n" "\0" > to buffer.

Should be:
SMEMCPY(&hs->hdr_content_len[len], CRLF '\0', 3);

Andrey Vinogradov <andreyvinogradov>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by andreyvinogradov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 13 Jun 2017 07:54:43 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1