bugGNU Octave - Bugs: bug #51344, [octave forge] (video) warning:...

 
 

bug #51344: [octave forge] (video) warning: comparison between signed and unsigned integer expressions

Submitter:  Nicholas Jankowski <nrjank>
Submitted:  Thu 29 Jun 2017 04:02:56 PM UTC
   
 
Category:  Octave Package Severity:  2 - Minor
Priority:  3 - Low Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Nicholas Jankowski Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 23 Nov 2021 07:27:01 AM UTC, comment #9: 

video 2.0.0 is a complete rewrite using OpenCV functions. Closing as fixed

Andreas Weber <andy1978>
Group Member
Sun 24 Nov 2019 07:36:59 AM UTC, comment #8: 

@sipan: "devel" is the new development branch. You can grab it, make release and try to install it.

Also see https://sourceforge.net/p/octave/video/ci/devel/tree/HACKING

You can report here for the new branch: https://savannah.gnu.org/bugs/?func=detailitem&item_id=57020

Andreas Weber <andy1978>
Group Member
Sun 24 Nov 2019 03:09:12 AM UTC, comment #7: 

I was asked to lelp installing octave-video on Fedora-31 and it looks like it is close to impossible.

comment #4:

> @nrank: the video package needs some changes to be compatible with GNU Octave 5.1.x. They have been made on the repo
>
> https://sourceforge.net/p/octave/video/ci/1d54438c2f8bf42bbcbbbdcc9c2aa66c0ecf828a/
>
> but there is no release yet. You can grab the repo and build from there in the meanwhile.


does not work. With all ffmpeg (and other ever mentioned) packages installed I am getting "Missing ffmpeg headers" and tonns of other errors  after

cd src
./bootstrap
./configure
make


> Currently I'm completley rewriting the video package (see devel branch) which will result in a drop of the avi* functions and implement the VideoReader and VideoWriter classes.


Is there a an outline of your re-write plan somewhere?

Sergey Panov <sipan>
Sat 02 Mar 2019 07:27:12 PM UTC, comment #6: 

mkoctfile issue added as bug #55814

Nicholas Jankowski <nrjank>
Group Member
Sat 02 Mar 2019 12:32:18 PM UTC, comment #5: 

Mike: Will reply with separate bug # after I post it.

Andy: no, not actively using it. Was just following up on the bug report after the new release.

Nicholas Jankowski <nrjank>
Group Member
Sat 02 Mar 2019 06:26:55 AM UTC, comment #4: 

@nrank: the video package needs some changes to be compatible with GNU Octave 5.1.x. They have been made on the repo

https://sourceforge.net/p/octave/video/ci/1d54438c2f8bf42bbcbbbdcc9c2aa66c0ecf828a/

but there is no release yet. You can grab the repo and build from there in the meanwhile.

Currently I'm completley rewriting the video package (see devel branch) which will result in a drop of the avi* functions and implement the VideoReader and VideoWriter classes.

Are y<ou actively using the video package and want to help?

-- Andy

Andreas Weber <andy1978>
Group Member
Fri 01 Mar 2019 10:15:27 PM UTC, comment #3: 

@nrjank Thanks for noticing that, that is a separate bug, can you file that? Something like "mkoctfile does not honor TMPDIR environment variable", I can confirm the same thing on Debian, not just a Windows thing.

As a workaround you can use the TEMP or TMP environment variables instead.

Mike Miller <mtmiller>
Group Member
Fri 01 Mar 2019 10:00:43 PM UTC, comment #2: 

my system currently has permission issues compiling in the user/appdata/temp location.  As such, I redefined tmpdir to another location prior to doing a pkg install using:

setenv('tmpdir','c:\programs\octave\temp')


verifying now, in the same session as the error below Octave gives


octave:7> tempdir
ans = c:\programs\octave\temp\


So why am I just noticing that at the end of that error block the pkg installer was tryig to use


C:\Users\NICHOL~1.JAN\AppData\Local\Temp/oct-Xa5crd.o


which is the normal location of TEMP and TMP in my system. is something in the installer looking at the system TEMP or TMP instead of my redefined tmpdir within octave? I can't tell from the message if this is the same permission error / compile failure I described in bug #55646 that was fixed by pointing octave's tmpdir elsewhere.

Nicholas Jankowski <nrjank>
Group Member
Fri 01 Mar 2019 09:51:50 PM UTC, comment #1: 

evaluating current state with v5.1.0 on Windows.  Granted 5.1.0 currently has the latest version. I tried to 'overinstall' the video package and got an install error.  (neglected to copy the error before closing Octave).  I then uninstalled video and attempted to reinstall producing the following install failure:


octave:7> pkg install -forge video
AVHandler.cc: In member function 'int AVHandler::read_frame(unsigned int)':
AVHandler.cc:358:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if ((uint64_t)vstream->start_time != AV_NOPTS_VALUE)
                                     ^
oct-avifile.cc: In member function 'void Avifile::addframe(const NDArray&)':
oct-avifile.cc:86:38: warning: format '%d' expects argument of type 'int', but argument 2 has type 'octave_idx_type {aka long long int}' [-Wformat=]
             frame_rows, frame_columns);
             ~~~~~~~~~~               ^
oct-avifile.cc:86:38: warning: format '%d' expects argument of type 'int', but argument 3 has type 'octave_idx_type {aka long long int}' [-Wformat=]
aviinfo.cc: In function 'std::__cxx11::string get_filedate(const string&)':
aviinfo.cc:42:3: error: 'octave_time' was not declared in this scope
   octave_time file_mod = file_stat (fn).mtime ();
   ^~~~~~~~~~~
aviinfo.cc:42:3: note: suggested alternative: 'octave_int'
   octave_time file_mod = file_stat (fn).mtime ();
   ^~~~~~~~~~~
   octave_int
aviinfo.cc:44:28: error: 'file_mod' was not declared in this scope
   return octave_localtime (file_mod).strftime ("%d-%b-%Y %H:%M:%S");
                            ^~~~~~~~
aviinfo.cc:44:28: note: suggested alternative: 'fileno'
   return octave_localtime (file_mod).strftime ("%d-%b-%Y %H:%M:%S");
                            ^~~~~~~~
                            fileno
aviinfo.cc:44:10: error: 'octave_localtime' was not declared in this scope
   return octave_localtime (file_mod).strftime ("%d-%b-%Y %H:%M:%S");
          ^~~~~~~~~~~~~~~~
aviinfo.cc:44:10: note: suggested alternative: 'octave_oct_time_h'
   return octave_localtime (file_mod).strftime ("%d-%b-%Y %H:%M:%S");
          ^~~~~~~~~~~~~~~~
          octave_oct_time_h
make: *** [Makefile:20: aviinfo.oct] Error 1
make: Entering directory '/c/programs/octave/temp/oct-X2pgyh/video-1.2.4/src'
C:/Programs/Octave/OCTAVE~1.0-W/mingw64/bin/mkoctfile-5.1.0.exe -Wall -v -Wno-deprecated-declarations -c -DHAVE_CONFIG_H AVHandler.cc -o AVHandler.o
g++ -c -I/release/mxe-octave-w64/usr/x86_64-w64-mingw32/include  -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2  -Wall -Wno-deprecated-declarations   -DHAVE_CONFIG_H AVHandler.cc -o AVHandler.o
C:/Programs/Octave/OCTAVE~1.0-W/mingw64/bin/mkoctfile-5.1.0.exe -Wall -v -Wno-deprecated-declarations -c -DHAVE_CONFIG_H oct-avifile.cc -o oct-avifile.o
g++ -c -I/release/mxe-octave-w64/usr/x86_64-w64-mingw32/include  -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2  -Wall -Wno-deprecated-declarations   -DHAVE_CONFIG_H oct-avifile.cc -o oct-avifile.o
C:/Programs/Octave/OCTAVE~1.0-W/mingw64/bin/mkoctfile-5.1.0.exe -Wall -v -Wno-deprecated-declarations -DHAVE_CONFIG_H avifile.cc AVHandler.o oct-avifile.o -lavformat -lavcodec -lswscale -lavutil -lpthread
g++ -c -I/release/mxe-octave-w64/usr/x86_64-w64-mingw32/include  -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2  -Wall -Wno-deprecated-declarations   -DHAVE_CONFIG_H avifile.cc -o C:\Users\NICHOL~1.JAN\AppData\Local\Temp/oct-wnAJWS.o
g++ -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2 -shared -Wl,-rpath-link,/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/qt5/lib -Wl,--export-all-symbols  -Wall -Wno-deprecated-declarations -o avifile.oct  AVHandler.o oct-avifile.o C:\Users\NICHOL~1.JAN\AppData\Local\Temp/oct-wnAJWS.o   -lavformat -lavcodec -lswscale -lavutil -lpthread -LC:\Programs\Octave\OCTAVE~1.0-W\mingw64\lib\octave\5.1.0 -LC:\Programs\Octave\OCTAVE~1.0-W\mingw64\lib -LC:\Programs\Octave\OCTAVE~1.0-W\mingw64\lib\octave\5.1.0 -loctinterp -loctave  -Wl,-rpath-link,/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/qt5/lib -Wl,--export-all-symbols
C:/Programs/Octave/OCTAVE~1.0-W/mingw64/bin/mkoctfile-5.1.0.exe -Wall -v -Wno-deprecated-declarations -DHAVE_CONFIG_H aviread.cc AVHandler.o oct-avifile.o -lavformat -lavcodec -lswscale -lavutil -lpthread
g++ -c -I/release/mxe-octave-w64/usr/x86_64-w64-mingw32/include  -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2  -Wall -Wno-deprecated-declarations   -DHAVE_CONFIG_H aviread.cc -o C:\Users\NICHOL~1.JAN\AppData\Local\Temp/oct-xtzT7x.o
g++ -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2 -shared -Wl,-rpath-link,/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/qt5/lib -Wl,--export-all-symbols  -Wall -Wno-deprecated-declarations -o aviread.oct  AVHandler.o oct-avifile.o C:\Users\NICHOL~1.JAN\AppData\Local\Temp/oct-xtzT7x.o   -lavformat -lavcodec -lswscale -lavutil -lpthread -LC:\Programs\Octave\OCTAVE~1.0-W\mingw64\lib\octave\5.1.0 -LC:\Programs\Octave\OCTAVE~1.0-W\mingw64\lib -LC:\Programs\Octave\OCTAVE~1.0-W\mingw64\lib\octave\5.1.0 -loctinterp -loctave  -Wl,-rpath-link,/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/lib -L/release/mxe-octave-w64/usr/x86_64-w64-mingw32/qt5/lib -Wl,--export-all-symbols
C:/Programs/Octave/OCTAVE~1.0-W/mingw64/bin/mkoctfile-5.1.0.exe -Wall -v -Wno-deprecated-declarations -DHAVE_CONFIG_H aviinfo.cc AVHandler.o oct-avifile.o -lavformat -lavcodec -lswscale -lavutil -lpthread
g++ -c -I/release/mxe-octave-w64/usr/x86_64-w64-mingw32/include  -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave\.. -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include\octave-5.1.0\octave -IC:\Programs\Octave\OCTAVE~1.0-W\mingw64\include   -fopenmp -g -O2  -Wall -Wno-deprecated-declarations   -DHAVE_CONFIG_H aviinfo.cc -o C:\Users\NICHOL~1.JAN\AppData\Local\Temp/oct-Xa5crd.o
make: Leaving directory '/c/programs/octave/temp/oct-X2pgyh/video-1.2.4/src'

pkg: error running `make' for the video package.
error: called from
    configure_make at line 99 column 9
    install at line 184 column 7
    pkg at line 441 column 9


Nicholas Jankowski <nrjank>
Group Member
Thu 29 Jun 2017 04:02:56 PM UTC, original submission:  

running 'pkg install -forge video' on a fresh Octave 4.2.1 install (64bit, zip installer, windows 7) produces the following warnings after downloading video-1.2.4.tar.gz:


AVHandler.cc: In member function 'int AVHandler::read_frame(unsigned int)':
AVHandler.cc:358:37: warning: comparison between signed and unsigned integer expres
sions [-Wsign-compare]
   if ((uint64_t)vstream->start_time != AV_NOPTS_VALUE)


realize this is a non-critical warning, but since the first thing new windows users often do is pkg update (same warnings when running pkg update), minimal spurious warnings would be preferable IMO.

Nicholas Jankowski <nrjank>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by sipan (Posted a comment)
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by nrjank (Submitted the item)
  • -email is unavailable- added by nrjank ((package maintainer))
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-23 andy1978 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2019-03-01 mtmiller Severity3 - Normal 2 - Minor
        Priority5 - Normal 3 - Low
        StatusNone Confirmed
        Release4.2.1 dev
        Operating SystemMicrosoft Windows Any
        Summary[octave forge] (video) update/install warnings 1.2.3--&gt;1.2.4 [octave forge] (video) warning: comparison between signed and unsigned integer expressions
    2018-07-02 jwe Summary[octave-forge] (video) update/install warnings 1.2.3--&gt;1.2.4 [octave forge] (video) update/install warnings 1.2.3-->1.2.4
    2017-08-12 jwe Summary[octave forge] video pkg update/install warnings 1.2.3--&gt;1.2.4 [octave-forge] (video) update/install warnings 1.2.3-->1.2.4
    2017-06-29 nrjank Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code