buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51517, Deprecate sys_arch_sem_wait and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51517: Deprecate sys_arch_sem_wait and sys_arch_mbox_fetch returning the time waited

Submitted by:  Douglas <ourairquality>
Submitted on:  Thu 20 Jul 2017 10:18:39 AM UTC  
 
Category: DocumentationSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Thu 20 Jul 2017 08:05:32 PM UTC, comment #2:

Mixed your proposal and my comments. Thanks for the patch.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 20 Jul 2017 07:28:52 PM UTC, comment #1:

I do support the summary. However, I think your patch goes too far: it's enough to say we don't need the "non-timeout" return values.

That way, existing implementations returning the wait time don't have to be changed. And there's no code in lwIP that would check for '0' anyway - it all checks for "!= SYS_ARCH_TIMEOUT".

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 20 Jul 2017 10:18:39 AM UTC, original submission:

Seems there might be some support for this change, so here's a proposal. Practically this just allows some implementations to simply these functions.

Douglas <ourairquality>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by ourairquality (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 20 Jul 2017 08:05:32 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Thu 20 Jul 2017 10:18:39 AM UTCourairqualityAttached File-=>Added 0001-Deprecate-sys_arch_sem_wait-and-sys_arch_mbox_fetch-.patch, #41263

    Back to the top


    Powered by Savane 3.1-cleanup1