buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51519, Clarify that sys_arch_protect()...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51519: Clarify that sys_arch_protect() always has a matching unprotect.

Submitted by:  Douglas <ourairquality>
Submitted on:  Thu 20 Jul 2017 12:34:05 PM UTC  
 
Category: DocumentationSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Thu 20 Jul 2017 07:24:23 PM UTC, comment #1:

Pushed, thanks for the patch. I really appreciate having someone with a somewhat outside view helping on the docs :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 20 Jul 2017 12:34:05 PM UTC, original submission:

The current documentation specifies sys_arch_unprotect() as resetting "the critical region protection to the value specified by pval". Such usage would not be compatible with implementations using a nesting counter, nor with many recursive mutex implementations, both of which require matching protect and unprotect operations.

Practically the current code seems to match protect and unprotect operations, so this is basically a warning that some implementations would break if there were not a matching unprotect for each protect operation. Also a warning that lwip code should not use the value returned by sys_arch_unprotect() except to pass it along.

Douglas <ourairquality>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by ourairquality (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 20 Jul 2017 07:24:23 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Thu 20 Jul 2017 12:34:05 PM UTCourairqualityAttached File-=>Added 0001-Clarify-that-sys_arch_protect-always-has-a-matching-.patch, #41264

    Back to the top


    Powered by Savane 3.1-cleanup1