buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51606, ip4_reass: Missing hole check when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51606: ip4_reass: Missing hole check when inserting pbuf in before another one

Submitted by:  Ambroz Bizjak <abizjak>
Submitted on:  Fri 28 Jul 2017 04:14:00 PM UTC  
 
Category: IPv4Severity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Wed 02 Aug 2017 07:12:26 PM UTC, comment #2:

Forget comment #1, I missed that lines 459ff only check from the received fragment to the end...

Fixed, thanks for reporting.

And added a unit test :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 02 Aug 2017 06:18:25 PM UTC, comment #1:

Doesn't lines 459 ff do this?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 28 Jul 2017 04:14:00 PM UTC, original submission:

http://git.savannah.gnu.org/cgit/lwip.git/tree/src/core/ipv4/ip4_frag.c?id=500598658df1d8674b7d25141983cf5452585d9d#n383

Where a pbuf is inserted before another one, there is no check if there is a hole between the new one and the previous one. There should be a check similar to line 437 where the new pbuf is inserted to the end.

Ambroz Bizjak <abizjak>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by abizjak (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Aug 2017 07:12:26 PM UTCgoldsimonStatusWorks For Me=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed
    Wed 02 Aug 2017 06:18:25 PM UTCgoldsimonStatusNone=>Works For Me

    Back to the top


    Powered by Savane 3.1-cleanup1