buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51694, tcp_receive trimming the first...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51694: tcp_receive trimming the first edge might produce bogus pbuf chains

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Tue 08 Aug 2017 09:06:57 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Wont Fix
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Mon 21 Aug 2017 08:36:15 PM UTC, comment #1:

Fixing this might make the code more unreadable (the first pbuf must stay allocated as long as anyone accesses inseg.tcphdr), so given the frequency this happens, it's probably better left as is.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Tue 08 Aug 2017 09:06:57 PM UTC, original submission:

The code seemed to be there forever: when trimming the first edge, first pbufs are set to "p->len = 0", which is kind of odd.

In addition to that, I'm not really sure the p->tot_len change is correct.

--> we need a unit test checking this :-/

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 21 Aug 2017 08:36:15 PM UTCgoldsimonStatusNone=>Wont Fix
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1