buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51765, pcb->dupacks > 3 logic added...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51765: pcb->dupacks > 3 logic added in 90873d6 not possible

Submitted by:  Joel Cunningham <jcunningham>
Submitted on:  Wed 16 Aug 2017 01:37:49 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: git head

Fri 25 Aug 2017 07:17:42 PM UTC, comment #1:

Right. Thanks for watching. The 'else' had to be removed:
call tcp_rexmit_fast() more than once on dupacks since the actual transmission is guarded by TF_INFR, not by pcb->dupacks

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 16 Aug 2017 01:37:49 PM UTC, original submission:

The dupacks > 3 logic added in 90873d6 is not possible to reach because the preceding if takes the > 3 case:

Joel Cunningham <jcunningham>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by jcunningham (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 25 Aug 2017 07:17:42 PM UTCgoldsimonItem GroupNone=>Faulty Behaviour
      StatusNone=>Fixed
      Assigned toNone=>goldsimon
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1