bugThe FreeType Project - Bugs: bug #51780, Inconsistency between ftoption.h...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51780: Inconsistency between ftoption.h and generated binary

Submitter:  Pavel Sountsov <siegelord>
Submitted:  Fri 18 Aug 2017 05:05:39 AM UTC
   
 
Severity:  3 - Normal Item Group:  Incorrect behaviour
Status:  Fixed Privacy:  Public
Assigned to:  wl Open/Closed:  Closed
Planned Release:  2.9

Tue 09 Apr 2019 02:14:49 PM UTC, comment #3: 

It should be straightforward to make autoconf add some comments to the final `ftoption.h' (and maybe add some comments to stderr/stdout also), indicating where the changes come from.  Would this help?

Werner LEMBERG <wl>
Group administrator
Tue 09 Apr 2019 01:13:26 PM UTC, comment #2: 

Werner,

I agree that autoconf has to be synchronized with ftoption.h. But I would argue that ftoption.h should take the priority. We should disregard command line options that disagree with ftoption.h. Quetly editting ftoption.h leads to unexpected consequences when users loses track of how ftoption.h was changed without their notice:

Bug 56036.
Bug 56073.

Even though these bugs pertain to cmake, it is not nice to make hard edits to files quetly. Is it possible to verify if a given configure option/outcome is consistent with ftoption.h instead?


Alexei Podtelezhnikov <podtelez>
Group Member
Sat 25 Nov 2017 10:51:44 PM UTC, comment #1: 

This should be fixed now in git, please test.

Werner LEMBERG <wl>
Group administrator
Fri 18 Aug 2017 05:05:39 AM UTC, original submission:  

I have fetched a copy of freetype-2.8 source and issued these commands on OSX:

./configure --prefix /tmp/freetype
make install

The first command printed out the following at the end:

Library configuration:
  external zlib: yes (autoconf test)
  bzip2:         yes (autoconf test)
  libpng:        yes (libpng-config)
  harfbuzz:      no

After compilation, I observed that the resultant freetype binary links to png, zlib and bzip2:

otool -L /tmp/freetype/lib/libfreetype.6.dylib
/tmp/freetype/lib/libfreetype.6.dylib:
    /tmp/freetype/lib/libfreetype.6.dylib (compatibility version
21.0.0, current version 21.0.0)
    /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
    /usr/lib/libbz2.1.0.dylib (compatibility version 1.0.0, current
version 1.0.5)
    /usr/local/opt/libpng/lib/libpng16.16.dylib (compatibility version
38.0.0, current version 38.0.0)
    /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
version 1213.0.0)

However, if I look at the corresponding ftoption.h, the options for system zlib, png and zlib2 are commented out, leading to an inconsistency.

As a point of comparison, if I use the CMake build system, then the ftoption.h that's installed actually does reflect the binary (because CMakeLists.txt modifies it in response to its configuration).

Pavel Sountsov <siegelord>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by podtelez (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by siegelord (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-25 wl StatusNone Fixed
        Assigned toNone wl
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.9

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code