bugGPSD - Bugs: bug #51894, pkg-config files broken in some...

 
 

bug #51894: pkg-config files broken in some build configurations

Submitted by:  Rolf Eike Beer <dakon>
Submitted on:  Wed 30 Aug 2017 08:30:17 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 30 Aug 2017 08:50:12 AM UTC, comment #1:

#45342 strikes back

Rolf Eike Beer <dakon>
Wed 30 Aug 2017 08:30:17 AM UTC, original submission:

In case either libdir or includedir is passed as an absolute path to scons the resulting .pc files are broken.

Example from openSUSE:

---
prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}//usr/lib64
includedir=${prefix}/include

Name: libgpsd
Description: Lowlevel GPSD control library
Version: 3.16
Cflags: -I${includedir}
Libs: -L${libdir} -lgpsd
---

The problems arise from these lines in the template:

libdir=${exec_prefix}/@libdir@

-> the full libdir is inserted, not one relative to ${exec_prefix} (which is just ${prefix}), which causes the duplication in case libdir is an absolute path

includedir=${prefix}/include

-> the user supplied includedir is never replaced here, e.g. if I passed "includedir=/usr/include/gpsd"

Rolf Eike Beer <dakon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by dakon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Sep 2017 11:35:01 AM UTCesrStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 07 Sep 2017 08:05:27 AM UTCdakonAttached File-=>Added 0001-fix-wrong-paths-showing-up-in-pkg-config-files.patch, #41754

    Back to the top


    Powered by Savane 3.1-cleanup1