buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51937, Leaking tcp_pcbs on passive close...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51937: Leaking tcp_pcbs on passive close with unacked data

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Mon 04 Sep 2017 06:40:03 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: 2.0.2

Sat 09 Sep 2017 07:48:09 PM UTC, comment #1:

Should be fixed in git master. Since this is in 2.0.x, we probably should roll out 2.0.3 soon...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Mon 04 Sep 2017 06:40:03 PM UTC, original submission:

When an application gets a FIN indication (recv callback with NULL pbuf) and calls 'tcp_close()' from this callback when not having all received data ACKed so far, the pcb can be leaked because it is removed from all pcb lists but the check for freeing it delayed is not executed any more when unwinding the call stack.

This is in since 2.0.0.

Suggested fix: move the "if (recv_flags & TF_CLOSED)" check in tcp_input() further down.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 09 Sep 2017 07:48:09 PM UTCgoldsimonStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1