bugThe FreeType Project - Bugs: bug #52218, cff font module now requires psaux

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52218: cff font module now requires psaux

Submitter:  bungeman <bungeman>
Submitted:  Thu 12 Oct 2017 06:27:10 PM UTC
   
 
Severity:  3 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  ewaldhew Open/Closed:  Closed
Planned Release:  2.9

Jump to the original submission

Tue 14 Nov 2017 06:00:49 AM UTC, comment #6: 

OK, closing.

Regarding the `enforcement', do you have suggestions how FreeType should behave and how to implement such behaviour?

Werner LEMBERG <wl>
Group administrator
Wed 01 Nov 2017 07:07:23 PM UTC, comment #5: 

As far as this bug report is concerned, I'm fine with the current resolution and would be fine with marking this as fixed. This change is at least discover-able at this point.

It would be nice if the comments about dependencies in modules.cfg were actually enforced (or at least warned about) in some way, but that seems to be a more general design discussion. I was mostly just concerned that others would also fall into this particular issue (update a custom static FreeType library build, everything compiles, but a few fonts silently stop working).

bungeman <bungeman>
Mon 16 Oct 2017 11:20:51 AM UTC, comment #4: 

Pushed to git.

Hew Yih Shiuan Ewald <ewaldhew>
Group Member
Mon 16 Oct 2017 09:22:24 AM UTC, comment #3: 

Please push this check :-)

Werner LEMBERG <wl>
Group administrator
Mon 16 Oct 2017 02:47:45 AM UTC, comment #2: 

Hi,

I've reproduced this issue and added a check in cffload.c:1598 (cff_done_blend) to check if the MultiMasters service is initialized. This should fix the segfault. modules.cfg will also be updated with the dependency notice.

As for failing the build where psaux is not built while its dependents are, I'm not actually sure how to do that. Change the make logic? I note that leaving out psaux while type1, cid, type42 are built doesn't seem to do anything wrt this either. (It builds, when used just fails and exits)

Hew Yih Shiuan Ewald <ewaldhew>
Group Member
Thu 12 Oct 2017 06:30:52 PM UTC, comment #1: 

Ewald, can you have a look, please?  I've assigned this issue to you.

Werner LEMBERG <wl>
Group administrator
Thu 12 Oct 2017 06:27:10 PM UTC, original submission:  

The change 1487be586e86cf3b0102a82fd4761416d96cc083 causes the cff font module to require the psaux auxiliary module, but this is not reflected in the comments in modules.cfg . Since the actual cff decoding is now in psaux it appears this is by design. So this is a request that the comment on the cff font module in modules.cfg be updated to reflect this dependency.

To reproduce the original issue which brought this up, comment out psaux in modules.cfg (and everything that claims to require it, but retaining the cff module). This causes loading a cff font in ftview to segfault (some of the loading code returns an error due to the missing module, but the clean up code for the partially constructed FT_Font fails on a nullptr dereference). This was discovered where FreeType was being built with a local build where type1, cid, and type42 support were not required, so psaux was not being built. It may be worth ensuring that any release notes make users aware of this change. It would be nice if the build actually failed in this case (instead of successfully creating a library which will segfault on some fonts).

While this change is certainly understandable (and probably not entirely over yet), it would also be nice to have a way to avoid building in any code not needed if only cff is required (which may still be possible without making psaux as a single object, but it would be nice to avoid that).

bungeman <bungeman>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ewaldhew (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by bungeman (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-14 wl StatusConfirmed Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.9
    2017-10-16 ewaldhew StatusNone Confirmed
    2017-10-12 wl Assigned toNone ewaldhew

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code