bugGPSD - Bugs: bug #52277, Add "RTCM 3" as a valid...

 
 

bug #52277: Add "RTCM 3" as a valid format string

Submitted by:  Wilkins White <atrer>
Submitted on:  Tue 24 Oct 2017 08:37:57 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Ready For Test
Privacy:  Public Assigned to:  Gary E. Miller <garyemiller>
Open/Closed:  Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 18 Dec 2017 04:42:13 PM UTC, comment #2:

The changes work great, thanks for taking care of it so quickly!

Here is an example line from the sourcetable, the full file is attached.

STR;IMAX_GG_RTCM3;IMAX_GG_RTCM3;RTCM 3;;2;GPS & GLO;ORGN;;42.38;-122.89;1;1;Leica GPS Spider;none;B;N;9600;Rover must send GGA

Wilkins White <atrer>
Sat 16 Dec 2017 02:50:50 AM UTC, comment #1:

Wilkins:

I just applied your patch to git head.

I'd like to add a regression test for this. Can you supply a short sample of data from this RTCM source?

can you confirm that git head now works for you?

Gary E. Miller <garyemiller>
Project AdministratorIn charge of this item.
Tue 24 Oct 2017 08:37:57 PM UTC, original submission:

The Oregon Real-Time GNSS Network provides a source table with format strings "RTCM 3"

Connecting causes the format to be identified as fmt_unknown in ntrip_str_parse, which then causes an error to be thrown. Could this format string (RTCM 3) be added to ntrip_str_parse (located in net_ntrip.c, line 64)? I noticed that "RTCM 2" is a valid option.

Just adding another "if" branch leading to fmt_rtcm3_0 is enough to fix it.

diff --git a/net_ntrip.c b/net_ntrip.c
index fe651e5..9322173 100644
--- a/net_ntrip.c
+++ b/net_ntrip.c
@@ -95,6 +95,8 @@ static void ntrip_str_parse(char *str, size_t len,
hold->format = fmt_rtcm3_1;
else if (strcasecmp("RTCM 3.2", s) == 0)
hold->format = fmt_rtcm3_2;
+ else if (strcasecmp("RTCM 3", s) == 0)
+ hold->format = fmt_rtcm3_0;
else
hold->format = fmt_unknown;
}

Wilkins White <atrer>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42673:  sourcetable.dat added by None (1KiB - application/octet-stream - Attaching the sourcetable. I'll check it out today, thanks!)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by garyemiller (Posted a comment)
  • -email is unavailable- added by atrer (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-12-18 None Attached File- => Added sourcetable.dat, #42673
    2017-12-16 garyemiller StatusFixed => Ready For Test
    2017-12-16 garyemiller StatusNone => Fixed
        Assigned toNone => garyemiller

    Back to the top


    Powered by Savane 3.3