bugicoutils - Bugs: bug #52319, wrestool -x null pointer read...

 
 

bug #52319: wrestool -x null pointer read access / segfault in extract_bitmap_resource

Submitted by:  Hanno Boeck <hanno>
Submitted on:  Tue 31 Oct 2017 07:27:51 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 Nov 2017 01:01:10 PM UTC, comment #1:

The attached patch fixes the segfault.

(file #42313)

Martin Gieseking <mgieseking>
Tue 31 Oct 2017 07:27:51 PM UTC, original submission:

Attached file will segfault wrestool -x.

asan stack trace:
==32031==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x00000050eac2 bp 0x7ffd0f83d920 sp 0x7ffd0f83d820 T0)
==32031==The signal is caused by a READ memory access.
==32031==Hint: address points to the zero page.
#0 0x50eac1 in extract_bitmap_resource /f/icoutils/wrestool/extract.c:291:5
#1 0x50eac1 in extract_resource /f/icoutils/wrestool/extract.c:96
#2 0x50e51f in extract_resources_callback /f/icoutils/wrestool/extract.c:45:11
#3 0x5142a5 in do_resources_recurs /f/icoutils/wrestool/restable.c:111:17
#4 0x513511 in do_resources /f/icoutils/wrestool/restable.c:71:5
#5 0x512aae in main /f/icoutils/wrestool/main.c
#6 0x7fd631a245dc in __libc_start_main (/lib64/libc.so.6+0x205dc)
#7 0x419ea9 in _start (/r/icoutils/wrestool+0x419ea9)

Hanno Boeck <hanno>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #42313:  nullptr.patch added by mgieseking (418B - text/x-patch)
file #42310:  nullptr.exe added by hanno (248B - application/x-ms-dos-executable)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mgieseking (Updated the item)
  • -unavailable- added by hanno (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 Nov 2017 01:01:10 PM UTCmgiesekingAttached File-=>Added nullptr.patch, #42313
    Tue 31 Oct 2017 07:27:51 PM UTChannoAttached File-=>Added nullptr.exe, #42310

    Back to the top


    Powered by Savane 3.1-cleanup1