bugThe libunwind project - Bugs: bug #52529, UNW_VERSION_MINOR should not be...

 
 

bug #52529: UNW_VERSION_MINOR should not be defined as a float

Submitted by:  Milan Bouchet-Valat <nalimilan>
Submitted on:  Mon 27 Nov 2017 09:51:47 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 27 Nov 2017 02:40:47 PM UTC, comment #1:

Ah, apparently this is already known and fixed at https://github.com/libunwind/libunwind/issues/30.

Milan Bouchet-Valat <nalimilan>
Mon 27 Nov 2017 09:51:47 AM UTC, original submission:

In version 1.2.1, UNW_VERSION_MINOR is defined as:
#define UNW_VERSION_MINOR 2.1

This triggered a build failure for Julia due to the fact that floating point values are not accepted by the preprocessor:
In file included from /usr/include/libunwind-x86_64.h:129:0,
from /usr/include/libunwind.h:25,
from /builddir/build/BUILD/julia-0.6.0/src/julia_internal.h:642,
from /builddir/build/BUILD/julia-0.6.0/src/typemap.c:7:
/builddir/build/BUILD/julia-0.6.0/src/julia_internal.h:646:35: error: floating constant in preprocessor expression
(UNW_VERSION_MAJOR == 1 && UNW_VERSION_MINOR > 1))

https://kojipkgs.fedoraproject.org/work/tasks/2353/23402353/build.log

Would it be possible to avoid using floating point values for this constant? AFAICT, this number is directly defined from the release number, so the problem only affects point releases. That means 1.3 should fix the problem, but 1.3.1 will reintroduce it, and so on.

I think a common convention is to have something like UNW_VERSION_PATCH for the third number.

Thanks in advance

Milan Bouchet-Valat <nalimilan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nalimilan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1