bugGPSD - Bugs: bug #52661, gpsd -V - Different version...

 
 

bug #52661: gpsd -V - Different version strings generated between shallow clone and full clone builds

Submitted by:  Jason Azze <jasonazze1>
Submitted on:  Wed 13 Dec 2017 09:41:08 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 31 May 2019 04:15:40 AM UTC, comment #3: 

I do not understand why this is a problem.

If you're building from either kind of repo and report a bug, there are two things I'd want the version string to convey:

1. That it's a build from repo rather than a stable release, and

2. When it was made, for bisection and troubleshooting purposes.

In a pinch I'd settle for just 2. Both formats do that OK.

I'm going to close this. If you think it's still a live issue, please explain why on the new bugtracker at https://gitlab.com/gpsd/gpsd/issues

Eric S. Raymond <esr>
Project Administrator
Tue 19 Dec 2017 01:37:29 PM UTC, comment #2: 

I think the bug was introduced in this commit:

"Fixes gratuitous rebuild in non-git directories"

http://git.savannah.nongnu.org/cgit/gpsd.git/commit/?id=f3f99af3ccfb84f7b5c5f95e7068fd662428e226

Jason Azze <jasonazze1>
Tue 19 Dec 2017 01:36:07 PM UTC, comment #1: 

I think this commit introduced this bug:

"Fixes gratuitous rebuild in non-git directories."
http://git.savannah.nongnu.org/cgit/gpsd.git/commit/?id=f3f99af3ccfb84f7b5c5f95e7068fd662428e226

Jason Azze <jasonazze1>
Wed 13 Dec 2017 09:41:08 PM UTC, original submission:  

A `scons build` done with a git shallow clone results in the version string:
`[master]:~/code/gpsd-shallow $ ./gpsd -V`
`./gpsd: 3.18~dev (revision 3.18~dev-2017-12-13T16:21:22.297582)`

A scons build done with a full clone results in the version string:
`[master]:~/code/gpsd-fullclone $ ./gpsd -V`
`./gpsd: 3.18~dev (revision release-3.17-26-ga78ca3d)`

By shallow clone, I mean:

`git clone --depth=1 http://git.savannah.gnu.org/r/gpsd.git gpsd-shallow`

Jason Azze <jasonazze1>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Posted a comment)
  • -email is unavailable- added by jasonazze1 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-31 esr Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5