bugThe FreeType Project - Bugs: bug #52917, Fix MSVC 19.00.23918 (Visual...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52917: Fix MSVC 19.00.23918 (Visual Studio 2017) compiler warnings.

Submitter:  Robin <robinsonuk>
Submitted:  Tue 16 Jan 2018 06:31:55 PM UTC
   
 
Severity:  3 - Normal Item Group:  Wishlist
Status:  Fixed Privacy:  Public
Assigned to:  wl Open/Closed:  Closed
Planned Release:  2.9.1

Tue 05 Jun 2018 05:49:09 AM UTC, comment #5: 

I'm closing this as fixed in newer releases.  Please open a new issue in case FreeType 2.9.1 still causes problems.

Werner LEMBERG <wl>
Group administrator
Fri 26 Jan 2018 04:50:39 AM UTC, comment #4: 

I even set EnableAllWarnings and mostly got suggestions on structure padding improvement.

(file #43086)

Alexei Podtelezhnikov <podtelez>
Group Member
Wed 17 Jan 2018 04:17:07 AM UTC, comment #3: 

All these warnings were fixed in 2.9. There is a new warning however:

Warning C4701 potentially uninitialized local variable 'fvar_head' used freetype freetype-2.9\src\truetype\ttgxvar.c 2137

This one is clearly false alarm but the code is hairy indeed, with divergent branches merging briefly in the middle.


Alexei Podtelezhnikov <podtelez>
Group Member
Tue 16 Jan 2018 08:08:19 PM UTC, comment #2: 

Thanks for the data.  Note, however, that the current FreeType release is 2.9 – a lot of code has changed meanwhile.

Please submit the same data with the current release.

Werner LEMBERG <wl>
Group administrator
Tue 16 Jan 2018 06:34:34 PM UTC, comment #1: 

Forgot to add the above was from a 64 bit build and includes the following, which are the warnings that show up in a 32 built.

1>ftstroke.c
...\e\freetype-2.8\src\cff\cffload.c(1368): warning C4244: '=': conversion from 'FT_UInt32' to 'FT_Byte', possible loss of data (compiling source file ..\..\..\src\cff\cff.c)
1>ftsystem.c
1>smooth.c
...\e\freetype-2.8\src\base\ftobjs.c(4995): warning C4702: unreachable code
...\e\freetype-2.8\src\base\ftobjs.c(4996): warning C4702: unreachable code

Robin <robinsonuk>
Tue 16 Jan 2018 06:31:55 PM UTC, original submission:  

Building Freetype 2.8, I get the following compiler warnings with Visual Studio 2017 (MSVC 19.00.23918):

...\e\freetype-2.8\src\psaux\t1decode.c(1356): warning C4267: '=': conversion from 'size_t' to 'FT_Int', possible loss of data (compiling source file ..\..\..\src\psaux\psaux.c)
...type1.c
...type1cid.c
...\e\freetype-2.8\src\sfnt\sfdriver.c(838): warning C4267: '=': conversion from 'size_t' to 'FT_UInt', possible loss of data (compiling source file ..\..\..\src\sfnt\sfnt.c)
...\e\freetype-2.8\src\sfnt\sfdriver.c(988): warning C4244: 'function': conversion from '__int64' to 'const unsigned int', possible loss of data (compiling source file ..\..\..\src\sfnt\sfnt.c)
1>type42.c
1>winfnt.c
...\e\freetype-2.8\src\truetype\ttgload.c(1711): warning C4312: 'type cast': conversion from 'unsigned long' to 'void *' of greater size (compiling source file ..\..\..\src\truetype\truetype.c)
...\e\freetype-2.8\src\type1\t1driver.c(269): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(289): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(321): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(351): warning C4267: '=': conversion from 'size_t' to 'FT_UInt', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(558): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(564): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(570): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(576): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1driver.c(582): warning C4267: '=': conversion from 'size_t' to 'FT_ULong', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1load.c(1528): warning C4244: '=': conversion from '__int64' to 'FT_Int', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type1\t1load.c(1689): warning C4244: '=': conversion from '__int64' to 'FT_Int', possible loss of data (compiling source file ..\..\..\src\type1\type1.c)
...\e\freetype-2.8\src\type42\t42parse.c(821): warning C4244: '=': conversion from '__int64' to 'FT_Int', possible loss of data (compiling source file ..\..\..\src\type42\type42.c)

Robin <robinsonuk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #43086:  warn.txt added by podtelez (71KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by podtelez (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by robinsonuk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-05 wl StatusNeed Info Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.9.1
    2018-01-26 podtelez Attached File- Added warn.txt, #43086
    2018-01-16 wl StatusNone Need Info
        Assigned toNone wl

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code