bugThe FreeType Project - Bugs: bug #53154, Prefer CBDT/CBLC over glyf in font...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #53154: Prefer CBDT/CBLC over glyf in font that has 'glyf' table

Submitter:  None
Submitted:  Wed 14 Feb 2018 10:02:27 AM UTC
   
 
Severity:  3 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  wl Open/Closed:  Closed
Planned Release:  2.9.1

Sat 03 Mar 2018 06:28:38 AM UTC, comment #4: 

I got no reply so it seems that it works as expected :-)

Closing.

Werner LEMBERG <wl>
Group administrator
Sat 17 Feb 2018 05:36:02 PM UTC, comment #3: 

Thanks for the patch!  I've rewritten it to make it more readable IMHO.  Now committed, please test.

Werner LEMBERG <wl>
Group administrator
Fri 16 Feb 2018 02:22:36 PM UTC, comment #2: 

Never mind my previous comment:

> Seems like this patch is not complete yet. With this patch, I seem to get incorrect vertical metrics through Skia and glyphs won't display. If I revert the patch, I see the glyphs okay in vertical text, but not in color.


This was due to a different issue in Blink's vertical text handling. So from my point of view, this patch is good to go, but would need review from someone who understands the code better than I do.

Dominik Röttsches <drott>
Wed 14 Feb 2018 11:13:55 AM UTC, comment #1: 

Seems like this patch is not complete yet. With this patch, I seem to get incorrect vertical metrics through Skia and glyphs won't display. If I revert the patch, I see the glyphs okay in vertical text, but not in color.

Dominik Röttsches <drott>
Wed 14 Feb 2018 10:02:27 AM UTC, original submission:  

Spinning of from the discussion in https://github.com/RoelN/ChromaCheck/issues/8

Behdad suggests to ignore glyf in CBDT/CBLC color fonts:
"We need to fix FreeType to ignore glyf table for CBDT fonts. We already do that for sbix. [...]"

I believe the sbix change he referred to is:
http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=778a7e6a36912303d9cb8b16b7aceacf3572d325

Going by that example, I tried to ignore outlines for CBLC/CBDT with glyf with a patch I am attaching. I am really new to this code and do not fully understand all the consequences of in sfnt_load_face() after assigning has_outline.




Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #43290:  0001-sfnt-Ignore-glyf-outlines-in-CBLC-CBDT-color-font.patch added by None (1KiB - application/octet-stream - Update logic to only ignore outlines when both tables are present)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by drott (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-03 wl StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-02-17 wl StatusNone Ready For Test
        Assigned toNone wl
        Planned ReleaseNone 2.9.1
    2018-02-14 None Attached File- Added 0001-sfnt-Ignore-glyf-outlines-in-CBLC-CBDT-color-font.patch, #43290
    2018-02-14 None Attached File- Added 0001-sfnt-Ignore-glyf-outlines-in-CBLC-CBDT-color-font.patch, #43288

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code