buglwIP - A Lightweight TCP/IP stack - Bugs: bug #54933, Bad assertion in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #54933: Bad assertion in lwip_poll_dec_sockets_used()

Submitter:  Joan Lledó <jllledo>
Submitted:  Thu 01 Nov 2018 05:14:53 PM UTC
   
 
Category:  sockets/netconn Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  2.2.0
lwIP version:  git head

Thu 01 Nov 2018 08:57:28 PM UTC, comment #1: 

Pushed, thanks for the patch.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 01 Nov 2018 05:14:53 PM UTC, original submission:  

Hello,

I wrote a patch to remove the assertion in lwip_poll_dec_sockets_used(), b/c it seems to me it allows clients to abort the stack by just calling poll() with an invalid pollfd array. In particular, any pollfd which 'fd' is not a valid port number makes the assertion true.

Besides, that assertion is not in lwip_poll_inc_sockets_used(), then I don't know why is it in lwip_poll_dec_sockets_used().

What do you think?

Joan Lledó <jllledo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jllledo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-01 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.2.0
    2018-11-01 jllledo Attached File- Added 0001-Remove-assertion-about-the-end-of-pollfd-array.patch, #45346

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code