bugPSPP - Bugs: bug #55156, Build failure when perl ld config...

 
 

bug #55156: Build failure when perl ld config value has multiple words

Submitter:  Ryan Carsten Schmidt <ryandesign>
Submitted:  Mon 03 Dec 2018 07:00:57 PM UTC
   
 
Category:  Compilation/Portability Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 02 Mar 2019 01:55:31 PM UTC, comment #1: 

I pushed this fix.  Thank you.

John Darrington <jmd>
Group administrator
Mon 03 Dec 2018 07:00:57 PM UTC, original submission:  

The pspp perl module can fail to build on systems where perl's ld config value contains multiple words. Here is a build failure on PowerPC Mac OS X Leopard:

https://build.macports.org/builders/ports-10.5_ppc_legacy-builder/builds/86402/steps/install-port/logs/stdio


'env MACOSX_DEPLOYMENT_TARGET=10.3 /usr/bin/gcc-4.2'  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc  -bundle -undefined dynamic_lookup -L/opt/local/lib -Wl,-headerpad_max_install_names  -fstack-protector PSPP.o  -o blib/arch/auto/PSPP/PSPP.bundle /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_math_pspp-devel/pspp-devel/work/pspp-1.2.0-ga8799b/src/.libs/libpspp-core.dylib \
              \

make[4]: env MACOSX_DEPLOYMENT_TARGET=10.3 /usr/bin/gcc-4.2: Command not found
make[4]: *** [blib/arch/auto/PSPP/PSPP.bundle] Error 127


The reason for the problem is that on this system, perl has determined that the value of ld should be multiple words, and the pspp perl module determines the perl value of ld by running $(PERL) -V::ld:, which apparently returns the raw value from the config, including quotation marks if any, which is then interpreted by the build as the name of a single command that should be run, which of course doesn't exist. I was able to fix the problem by using Config::Perl::V directly, which gets the value inside the quotation marks. See attached patch.

Ryan Carsten Schmidt <ryandesign>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by ryandesign (Submitted the item)
  • -email is unavailable- added by ryandesign
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-02 jmd CategoryOther Compilation/Portability
        StatusNone Fixed
        Open/ClosedOpen Closed
    2018-12-03 ryandesign Attached File- Added 21c4fda59fbeef7ca9fb7bad54c7797a2cd90081.patch, #45571
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code