bugGPSD - Bugs: bug #55291, osX unhappy with gpsrinex.c

 
 

bug #55291: osX unhappy with gpsrinex.c

Submitter:  Gary E. Miller <garyemiller>
Submitted:  Wed 26 Dec 2018 10:44:57 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 31 May 2019 10:13:03 AM UTC, comment #2: 

I've lookee atr the code and it appears that last glitch has been fixed by making the literal "{{0}}".

Therefore, closing this.

Eric S. Raymond <esr>
Group administrator
Fri 28 Dec 2018 03:38:28 AM UTC, comment #1: 

Fixed all but this one:

 gpsrinex.c:142:22: warning: suggest braces around initialization of subobject

Gary E. Miller <garyemiller>
Group administrator
Wed 26 Dec 2018 10:44:57 PM UTC, original submission:  

The complaints:




gpsrinex.c:142:22: warning: suggest braces around initialization of subobject [-
Wmissing-braces]
} obs_cnt[MAXCNT] = {0};
^
{}
gpsrinex.c:209:19: warning: result of comparison of constant 99999 with expressi
on of type 'obs_codes' is always false [-Wtautological-constant-out-of-range-compare]
if (99999 < obs_cnt[i].obs_cnts[obs_code]) {
~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gpsrinex.c:560:11: warning: implicitly declaring library function 'snprintf' with type 'int (char *, unsigned long, const char *, ...)' [-Wimplicit-function-declaration]
(void)snprintf(buf, sizeof(buf), "%14.3f%c%1c", val, lli_c, snr_c);
^
gpsrinex.c:560:11: note: include the header <stdio.h> or explicitly provide a declaration for 'snprintf'
gpsrinex.c:833:21: warning: implicitly declaring library function 'strdup' with type 'char *(const char *)' [-Wimplicit-function-declaration]
fname = strdup(optarg);
^
gpsrinex.c:833:21: note: include the header <string.h> or explicitly provide a declaration for 'strdup'
4 warnings generated.

Gary E. Miller <garyemiller>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Posted a comment)
  • -email is unavailable- added by garyemiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-31 esr Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code