bugGPSD - Bugs: bug #56319, UBX Driver does not set status in...

 
 

bug #56319: UBX Driver does not set status in NAV-SOL if mode is NO-FIX

Submitted by:  None
Submitted on:  Mon 13 May 2019 04:54:34 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 31 May 2019 04:22:25 AM UTC, comment #1: 

Closing, as this patch is no longer applicable after Gary's rewrite for UBX-9.

Eric S. Raymond <esr>
Project Administrator
Mon 13 May 2019 04:54:34 PM UTC, original submission:  

The routine ubx_msg_nav_sol in driver_ubx.c does not set status if the mode is MODE_NO_FIX. Lines 375 to 378:

    if ((flags & UBX_SOL_FLAG_DGPS) != 0)
session->gpsdata.status = STATUS_DGPS_FIX;
    else if (session->newdata.mode != MODE_NO_FIX)
session->gpsdata.status = STATUS_FIX;

This should be:
      if ((flags & UBX_SOL_FLAG_DGPS) != 0)
session->gpsdata.status = STATUS_DGPS_FIX;
    else if (session->newdata.mode != MODE_NO_FIX)
session->gpsdata.status = STATUS_FIX;
    else
        session->gpsdata.status = STATUS_NO_FIX;

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-31 esr Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5