lwIP - A Lightweight TCP/IP stack - Bugs: bug #57481, Lease timeout timers overflow
You are not allowed to post comments on this tracker with your current authentication level.
bug #57481: Lease timeout timers overflow
Submitter: | S. Janek <sjanek> | ||
Submitted: | Thu 26 Dec 2019 03:17:50 AM UTC | ||
Category: | DHCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Invalid |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Fri 03 Jan 2020 08:31:45 AM UTC, comment #1: |
Simon Goldschmidt <goldsimon> |
Thu 26 Dec 2019 03:17:50 AM UTC, original submission:
Hi,
|
S. Janek <sjanek> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-01-03 | goldsimon | Status | None | Invalid | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2019-12-26 | sjanek | Carbon-Copy | - | Added sjanek |
Powered by Savane 3.13-758e.
Corresponding source code
I think your analysis is wrong: those timeout values are in DHCP_COARSE_TIMER_SECS, which is one minute, so you have to divide your overflow calculation by 60. So the maximum value for those timers will be ~45 days.
Also, the value is not just assigned. It is checked for overflow and limited to 0xffff instead of overflowing.
In the old days where people actually cared for every byte, we decided that 45 days should be more than enough and it should be ok to trim here.