buglwIP - A Lightweight TCP/IP stack - Bugs: bug #58141, mDNS: mixed usage of (un)signed...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58141: mDNS: mixed usage of (un)signed for same variable

Submitted by:  Jasper Verschueren <jasperv>
Submitted on:  Wed 08 Apr 2020 09:33:13 AM UTC  
 
Category:  apps Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None
lwIP version:  git head

Mon 11 May 2020 01:35:42 PM UTC, comment #3: 

Attached you can find the correct patch.

I used MDNS_MAX_SERVICES as the error code for function mdns_resp_add_service().
Using the same return value for two types is not nice coding.
So we should not use it as err_t and slot number.
This is now corrected.

(file #49056)

Jasper Verschueren <jasperv>
Thu 09 Apr 2020 07:47:21 AM UTC, comment #2: 

Ok, sorry I should have better checked this.
I'm updating my lwIP version and I'll make a good/tested patch.

Jasper Verschueren <jasperv>
Thu 09 Apr 2020 07:43:20 AM UTC, comment #1: 

That doesn't completely work: mdns_resp_add_service() returns a negative number (an err_t) on failure.

Simon Goldschmidt <goldsimon>
Project Administrator
Wed 08 Apr 2020 09:33:13 AM UTC, original submission:  

The slot variable was changed to u8_t but not everywhere.
s8_t is still used in some places, this patch changes that and
now only u8_t is used.

I did not compile the patch as I did not update to the latest master yet. But it's simple enough, so I the patch should be good.

Jasper Verschueren <jasperv>

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jasperv (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-11 jasperv Attached File- => Added 0001-mdns-fixes-mixed-usage-of-signed-and-unsigned-for-sa.patch, #49056
    2020-04-08 jasperv Attached File- => Added 0001-mdns-fixes-mixed-usage-of-signed-and-unsigned-for-sa.patch, #48783

    Back to the top


    Powered by Savane 3.6