bugmonotone - Bugs: bug #6113, LCA calculation is screwy

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #6113: LCA calculation is screwy

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Wed 22 Oct 2003 06:49:54 AM UTC  
 
Category: merge algorithmSeverity: 3 - Normal
Item Group: incorrect behaviorStatus: Fixed
Privacy: PublicAssigned to: graydon hoare <graydon>
Open/Closed: Closed
mtn version --full: 

Sun 21 Mar 2004 01:33:49 AM UTC, comment #2:

uses dominator/ancestor intersection now. seems to work.

graydon hoare <graydon>
Project MemberIn charge of this item.
Mon 03 Nov 2003 02:54:28 AM UTC, comment #1:

I'm pretty sure this is fixed by placing the start nodes in each of the left and right ancestor groups during LCA. we discussed online and I think it's fixed now.

graydon hoare <graydon>
Project MemberIn charge of this item.
Wed 22 Oct 2003 06:49:54 AM UTC, original submission:

See attached modified screenshot for ancestry graph involved in this.

Basically, I had heads "zifen-lezan" (9ddc) and "iwupe-hazal" (dc06). iwupe-hazal's immediate parent is "vohas-dikuk" (8a76); vohas-dikuk is also a (transitive) parent of zifen-lezan. One would expect, then, that a call to monotone merge would do a merge of zifen and iwupe, using vohas as the LCA. But no; in fact "ludes-zufaf" (4a96) was used as the LCA. I have no idea why.

The merge itself also had lots of fun spurious conflicts. I think some of these were because of the incorrect choice of LCA, but there were also some files that ediff found no conflicts on ($$ eliminated all hunks, not just some of them...).

Nathaniel Smith <njs>
Project Member

 

Attached Files
file #748:  lca-bug.png added by njs (23KiB - image/png - Ancestry graph when bug occurred)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 21 Mar 2004 01:33:49 AM UTCgraydonOpen/ClosedIn Test=>Closed
Mon 03 Nov 2003 02:54:28 AM UTCgraydonStatusNone=>(Error - Not Found)
  Assigned toNone=>NA
  Open/ClosedOpen=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1