bugStraw, desktop news aggregator - Bugs: bug #6619, [PATCH] Two bugs found..

 
 

bug #6619: [PATCH] Two bugs found..

Submitted by:  Jeremy Messenger <mezz>
Submitted on:  Mon 17 Nov 2003 11:20:28 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 28 Feb 2004 11:25:02 AM UTC, comment #9:

Fixed.

Jan Alonzo <jmalonzo>
Project Administrator
Sun 04 Jan 2004 12:12:08 PM UTC, comment #8:

mezz,

Hi, can you test patch-8 from my experimental branch? It should fix this bug. Basically, we have to encode the titles, feed and item titles, to utf-8 (it's a patch to MainWindow.py)

Thanks.

Jan Alonzo <jmalonzo>
Project Administrator
Wed 26 Nov 2003 06:16:28 PM UTC, comment #7:

Maybe, if you setup the locale in the different way and you might reproduce this bug? I don't have any Linux machine around, so here's what the locale looks like to reproduce this bug.

============================
$ locale
LANG=en_US.ISO8859-1
LC_CTYPE="en_US.ISO8859-1"
LC_COLLATE="en_US.ISO8859-1"
LC_TIME="en_US.ISO8859-1"
LC_NUMERIC="en_US.ISO8859-1"
LC_MONETARY="en_US.ISO8859-1"
LC_MESSAGES="en_US.ISO8859-1"
LC_ALL=
============================

I can't reproduce this bug if it looks like this:

============================
$ locale
LANG=
LC_CTYPE="C"
LC_COLLATE="C"
LC_TIME="C"
LC_NUMERIC="C"
LC_MONETARY="C"
LC_MESSAGES="C"
LC_ALL=
============================

Hope, it will help a little bit.

BTW: I just submitted the straw-devel mailing list.

Jeremy Messenger <mezz>
Wed 26 Nov 2003 12:03:11 PM UTC, comment #6:

Damn shame I can't reproduce this bug, would make easier to try to find out what the problem is. But thanks for the error output, it should help things along... I'll try to look into this one of these days and see if I can find out the source of this problem.

Juri Pakaste <juri>
Project Administrator
Wed 26 Nov 2003 06:29:48 AM UTC, comment #5:

Ok, here are answers.. I just setup the different locale in my local machine and I collected the stuff. Here are two attaches.

error-straw.txt - Here's error what I get.
straw.png - Screenshot of what it looks like.

If I use the patch-src::lib::utils.py patch and it solve 100% of this problem.

>> The article list(upper right pane) or the item view(lower right pane)?


Both...

Jeremy Messenger <mezz>
Wed 26 Nov 2003 03:40:15 AM UTC, comment #4:

> The new release includes the patch in utils.py and fixes the Makefile as well.


Yeah, I saw.. Thanks!

> Are you on straw-devel list by any chance?


No, but I can submit there.

> and what do you mean by "article in the right side"?


Ya know, the 'Articles:'? The two boxes in the right side just doesn't display anything when you click on any of feeder in the left side. It's hard for me to explain, because this bug doesn't hit on me but to many other users. I will have to ask someone and ask him to see if he can take a screenshot of it.

I am just a maintainer for Straw in FreeBSD ports tree, so I just take their reports in here.

> The article list(upper right pane) or the item view(lower right pane)?


Umm, good question. I will have to ask someone again and take the screenshot.

Jeremy Messenger <mezz>
Wed 26 Nov 2003 12:12:48 AM UTC, comment #3:

The new release includes the patch in utils.py and fixes the Makefile as well. Are you on straw-devel list by any chance? and what do you mean by "article in the right side"? The article list(upper right pane) or the item view(lower right pane)?

Jan Alonzo <jmalonzo>
Project Administrator
Tue 25 Nov 2003 09:13:14 PM UTC, comment #2:

> Did Straw throw any exceptions without that patch, or otherwise whine to stderr/stdout?


No error or whatever at all. The article in the right side will not display anything at all. This patch fix the problem to allow the FreeBSD users to viewable the articles if they have the locale set other than C.

If you have anything else you have in the mind, just let me know and I can ask few users to do the test for us with your new changes.

Jeremy Messenger <mezz>
Tue 25 Nov 2003 04:36:19 PM UTC, comment #1:

Jan already committed the utils.py patch, but I have my doubts about that one, it seems to do the wrong thing in the wrong place, even if it has the desired effect. We shouldn't be converting anything internally into utf-8 except in the display routines, and most certainly not one character at a time.

Did Straw throw any exceptions without that patch, or otherwise whine to stderr/stdout?

Juri Pakaste <juri>
Project Administrator
Mon 17 Nov 2003 11:20:28 PM UTC, original submission:

- patch-src::lib::utils.py: Fix a problem where straw wouldn't show any articles if the locale was set
to anything other than C. It's on FreeBSD, btw.

- patch-src::lib::Config.py: Make sure we persist articles across reboots. Well, this one, the real solution is to fix the gconf in the Makefile. It doesn't do the correct way to install gconf, so it's bug.

Those patches were created by Joe Marcus Clarke <marcus_at_FreeBSD.org>.

Jeremy Messenger <mezz>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #876:  straw.png added by mezz (22KiB - image/png)
file #875:  error-straw.txt added by mezz (1KiB - text/plain)
file #841:  patch-src::lib::Config.py added by mezz (375B - application/octet-stream)
file #840:  patch-src::lib::utils.py added by mezz (360B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 28 Feb 2004 11:25:02 AM UTCjmalonzoStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1