bugmonotone - Bugs: bug #7221, [NEED TEST] "monotone...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #7221: [NEED TEST] "monotone cert" should not require its target be on a branch

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Tue 13 Jan 2004 11:39:39 AM UTC  
 
Category: command line UISeverity: 1 - Wish
Item Group: incorrect behaviorStatus: Fixed
Privacy: PublicAssigned to: Stephen Leake <stephen_leake>
Open/Closed: Closed
mtn version --full: 

Mon 10 May 2010 10:01:59 AM UTC, comment #4:

test updated in b19661370e3fc21fb0a1b3c060ce7acc48737912

Stephen Leake <stephen_leake>
Project MemberIn charge of this item.
Sun 09 May 2010 10:13:08 PM UTC, comment #3:

The original problem has indeed be fixed in the meantime, but your test doesn't test that. The use case is:

$ mtn ci -b "ugly-branch-name" -m "test"
$ mtn db kill_branch_certs_locally "ugly-branch-name"
$ mtn cert $(mtn au get_base_revision_id) "branch" "better-branch-name"

Could you please update your test accordingly? Thanks!

Thomas Keller <tommyd>
Project Administrator
Sat 08 May 2010 06:59:55 PM UTC, comment #2:

0.47 doesn't require a branch for 'mtn cert', but I could not find a test for it. So I added one. rev efce0af84dbe5a17d9fbcbbcbc13afcfc0d02460

Stephen Leake <stephen_leake>
Project MemberIn charge of this item.
Mon 21 Feb 2005 11:48:21 PM UTC, comment #1:

This bug needs a (possibly XFAILed) test written.

Nathaniel Smith <njs>
Project Member
Tue 13 Jan 2004 11:39:39 AM UTC, original submission:

Just was trying to fix a little screw up in my local database, so I used sqlite to delete a branch cert from a version, and then tried to use monotone to add a new one back on.

~/src/monotone$ clean/monotone --db=monotone.db cert manifest d4ee branch 'net.venge.monotone'
monotone: expanded partial id 'd4ee' to 'd4ee560ee25663c18168c9750ad571e5fa3f1b5b'
monotone: misuse: no branch certs found for manifest d4ee560ee25663c18168c9750ad571e5fa3f1b5b, please provide a branch name

        • error return code 1
                    • errors detected; see standard output for details ***********

..well, yeah, it's not on a branch, that's the whole point...

Adding --branch=net.venge.monotone worked as a workaround, but it seems silly that "monotone cert" should fail in the absence of a branch cert.

Nathaniel Smith <njs>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tommyd (Posted a comment)
  • -unavailable- added by stephen_leake (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 16 May 2010 09:26:07 AM UTCstephen_leakeOpen/ClosedIn Test=>Closed
    Mon 10 May 2010 10:01:59 AM UTCstephen_leakeOpen/ClosedAccepted=>In Test
    Sun 09 May 2010 10:13:08 PM UTCtommydOpen/ClosedIn Test=>Accepted
    Sat 08 May 2010 06:59:55 PM UTCstephen_leakeStatusNone=>Fixed
      Open/ClosedOpen=>In Test
    Sat 08 May 2010 06:23:06 PM UTCstephen_leakeAssigned toNone=>stephen_leake
    Mon 21 Feb 2005 11:48:21 PM UTCnjsSummary"monotone cert" should not require its target be on a branch=>[NEED TEST] "monotone cert" should not require its target be on a branch

    Back to the top


    Powered by Savane 3.1-cleanup1