bugmldonkey, a multi-networks file-sharing client - Bugs: bug #7633, commands_frame_height option not...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #7633: commands_frame_height option not saved

Submitted by:  None
Submitted on:  Sun 08 Feb 2004 05:48:58 PM UTC  
 
Category: HTTP interfaceSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: allRelease: None
Operating System: LinuxBinaries Origin: CVS / Self compiled
CPU type: None

Tue 02 Mar 2004 12:31:11 AM UTC, comment #4:

Please see patch 2724 for better standard values.
commands_frame_height is changed when html_themes is changed, this is not a bug, it is a feature.

spiralvoice <spiralvoice>
Project Administrator
Wed 25 Feb 2004 12:35:36 AM UTC, comment #3:

Here is what I did: changed commands_frame_height from 42 to 60, stopped core and restarted, value was preserved and not changed as experienced by you.

Default value when no ini file is present is 42.

Changing html_themes changes the value of commands_frame_height, this is not a bug its a feature:
see src/daemon/common/commonGlobals.ml, line 658-661

(* Name,FrameHeight *)
let html_mods_styles = ref
[| ("Green",45) ; ("Tang",45); ("L.Blue",45);
("L.Purple",45); ("Monochrome",45); ("Corona",45); |]

There the 45 comes from. This is not in line with the default of 42, so if this is annoying a patch will help;-)

spiralvoice <spiralvoice>
Project Administrator
Mon 09 Feb 2004 07:24:22 PM UTC, comment #2:

Yes that's right. The problem is not there.

I notice something else : you just have to change html theme to restore a default value of 45 (which is even not the real default value of 42). Any change to this option is erased on a change of theme, or reload mlnet.

Anonymous
Mon 09 Feb 2004 12:06:01 AM UTC, comment #1:

In current CVS (2.5.9) there is no downloads_expert.ini anymore and it seems from commonOptions.ml that this
option is only present once.

spiralvoice <spiralvoice>
Project Administrator
Sun 08 Feb 2004 05:48:58 PM UTC, original submission:

In section "html", commands_frame_height option is in 2 ini files : downloads.ini and downloads_expert.ini. There seems to conflict each other. Anyway, you can change the value for one session, but it's not saved correctly and an old value is restored next time you launch mlnet.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 02 Mar 2004 12:31:11 AM UTCspiralvoiceStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1