bugmldonkey, a multi-networks file-sharing client - Bugs: bug #7741, No donkey servers can ever become...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #7741: No donkey servers can ever become `masters'

Submitted by:  None
Submitted on:  Mon 16 Feb 2004 08:12:08 AM UTC  
 
Category: eDonkey-PluginSeverity: 1 - Wish
Item Group: Program malfunctionStatus: None
Assigned to: NoneOpen/Closed: Closed
Release: 2.5-10Release: 2-5-10
Operating System: LinuxBinaries Origin: CVS / Self compiled
CPU type: None

(Jump to the original submission Jump to the original submission)

Thu 14 Oct 2004 12:16:52 PM UTC, comment #6:

This bug should be solved in the current version.
Please download it and report a new bug if the problem still exists.

spiralvoice <spiralvoice>
Project Administrator
Tue 10 Aug 2004 06:43:25 PM UTC, comment #5:

Changing severity to 1 because this bug might be solved in current CVS release.

spiralvoice <spiralvoice>
Project Administrator
Mon 09 Aug 2004 06:30:56 PM UTC, comment #4:

Please test CVS 2-5-25 and report if the bugs is still present.

spiralvoice <spiralvoice>
Project Administrator
Sun 25 Jul 2004 09:50:03 PM UTC, comment #3:

How can I see that a server became master server?

spiralvoice <spiralvoice>
Project Administrator
Wed 31 Mar 2004 10:48:01 PM UTC, comment #2:

I'm pretty sure that I understand the cause, and I'm absolutely sure that it's currently broken.

For added confusion, there are two definitions of update_master_servers in the one file. (src/networks/donkey/donkeyServers.ml)

Removing the sole occurrence of connection_ok s.server_connection_control from donkeyClient.ml fixed this for me.

Anonymous
Fri 12 Mar 2004 03:09:21 PM UTC, comment #1:

Are you sure ?
This seems correct to me :

if not s.server_master && s.server_cid <> None then
if !nmasters < max_allowed_connected_servers () &&
s.server_nusers >= !!master_server_min_users
then begin
do_if_connected s.server_sock (fun sock ->
s.server_master <- true;
incr nmasters;
direct_server_send_share s.server_has_zlib sock
(DonkeyShare.all_shared ())
)
end else
if connection_last_conn s.server_connection_control

Did you noticed the "else" before "if connection last..."?

HighTime <HighTime>
Mon 16 Feb 2004 08:12:08 AM UTC, original submission:

A requirement for donkey servers to become `masters' is that the candidate must have been connected for at least two minutes; however, this time is reset every time a response to any query is received, perhaps due to the slightly misleading name of the call used to set this: connection_ok. Queries are sent at least once every minute and no workaround seems possible because file_queries_initial_delay is current ineffectual. (i.e. MLDonkey kills the network - again.)

No other networks seem to have such mistakes, although it is worth checking.

Anonymous

 

Attached Files
file #1576:  donkey_server_master.patch added by spiralvoice (533B - application/octet-stream - please try this patch - not tested)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 14 Oct 2004 12:16:52 PM UTCspiralvoiceOpen/ClosedOpen=>Closed
Tue 10 Aug 2004 06:43:25 PM UTCspiralvoiceSeverity3 - Normal=>1 - Wish
Fri 23 Jul 2004 12:39:49 AM UTCspiralvoiceAttached File-=>Added donkey_server_master.patch, #1514
Tue 02 Mar 2004 09:08:55 PM UTCspiralvoiceItem GroupNone=>Program malfunction
  ReleaseNone=>2-5-10

Back to the top


Powered by Savane 3.1-cleanup1